videolan/vlc - vlc - Gitea: Git with a cup of tea

History

Thomas Guillem 90e98b012e vlc_queue: fix restrict violation `restrict` tells the compiler that the tombstone pointer is the only way to access the variable pointed by it. This is not case with multi-threading. From the C11 specs: § 6.7.3 item 8 An object that is accessed through a restrict-qualified pointer has a special association with that pointer. This association, defined in 6.7.3.1 below, requires that all accesses to that object use, directly or indirectly, the value of that particular pointer. § 6.7.3.1 item 4 Every other lvalue used to access the value of X shall also have its address based on P. Also set the pointer to const. Fixes the following race condition when closing live555: Thread 80 (Thread 28393.4880): 0 0x0000007953dbebbc in syscall () from /home/tom/work/git/libvlcjni/libvlc/.gdb/obj/local/arm64-v8a/system/lib64/libc.so 1 0x0000007855d2c0ec in sys_futex (addr=0x89, op=137, val=0, to=0x0, addr2=0x0, val3=-1) at ../../src/linux/thread.c:82 2 vlc_futex_wait (addr=0x89, flags=0, val=0, to=0x0) at ../../src/linux/thread.c:93 3 vlc_atomic_wait (addr=0x89, val=0) at ../../src/linux/thread.c:109 4 0x0000007855d20e9c in vlc_cond_wait (cond=cond@entry=0x7829f26ce8, mutex=mutex@entry=0x7829f26cd8) at ../../src/misc/threads.c:298 5 0x0000007855d42244 in vlc_queue_Wait (q=0x7829f26cc0) at ../../include/vlc_queue.h:122 6 vlc_queue_DequeueKillable (q=0x7829f26cc0, tombstone=0x7829f26d00) at ../../include/vlc_queue.h:248 7 vlc_stream_fifo_Block (s=<optimized out>, eof=0x78709a8838) at ../../src/input/stream_fifo.c:75 8 0x0000007855cfa160 in vlc_stream_ReadRaw (s=s@entry=0x7819411360, buf=buf@entry=0x78c4393c80, len=len@entry=188) at ../../src/input/stream.c:466 9 0x0000007855cf9fe0 in vlc_stream_ReadPartial (s=s@entry=0x7819411360, buf=buf@entry=0x78c4393c80, len=len@entry=188) at ../../src/input/stream.c:489 10 0x0000007855cfad44 in vlc_stream_Read (s=<optimized out>, buf=0x78c4393c80, len=188) at ../../src/input/stream.c:504 11 vlc_stream_Block (s=0x7819411360, size=<optimized out>) at ../../src/input/stream.c:909 12 0x0000007855f1fe5c in ReadTSPacket (p_demux=p_demux@entry=0x78c42c0ce0) at ../../modules/demux/mpeg/ts.c:1808 13 0x0000007855f1de30 in Demux (p_demux=<optimized out>) at ../../modules/demux/mpeg/ts.c:649 4 0x0000007855d41e4c in vlc_demux_chained_Thread (data=0x7829f26c70) at ../../src/input/demux_chained.c:96 15 0x0000007855d2d5b8 in joinable_thread (data=0x7823341ea0) at ../../src/android/thread.c:96 16 0x0000007953e217c4 in __pthread_start(void) () from /home/tom/work/git/libvlcjni/libvlc/.gdb/obj/local/arm64-v8a/system/lib64/libc.so 17 0x0000007953dc41ac in __start_thread () from /home/tom/work/git/libvlcjni/libvlc/.gdb/obj/local/arm64-v8a/system/lib64/libc.so Thread 79 (Thread 28393.4875): 0 0x0000007953dbebbc in syscall () from /home/tom/work/git/libvlcjni/libvlc/.gdb/obj/local/arm64-v8a/system/lib64/libc.so 1 0x0000007953e21d98 in pthread_join () from /home/tom/work/git/libvlcjni/libvlc/.gdb/obj/local/arm64-v8a/system/lib64/libc.so 2 0x0000007855d2d204 in vlc_join (handle=0x7823341ea0, result=0x0) at ../../src/android/thread.c:147 3 0x0000007855d4202c in vlc_demux_chained_Delete (dc=0x7829f26c70) at ../../src/input/demux_chained.c:167 4 0x0000007855d3d92c in Close (p_this=<optimized out>) at ../../modules/access/live555.cpp:505 5 0x0000007855cb49dc in module_unneed (obj=obj@entry=0x78194110c0, module=0x78c83b0520) at ../../src/modules/modules.c:305 6 0x0000007855ceae78 in vlc_access_Destroy (access=0x78194110c0) at ../../src/input/access.c:54 7 0x0000007855cf958c in vlc_stream_Delete (s=0x78194110c0) at ../../src/input/stream.c:150 8 0x0000007855ce4954 in demux_Delete (demux=0x78709a8d60) at ../../include/vlc_demux.h:291 9 InputSourceDestroy (in=0x781a3aa780) at ../../src/input/input.c:2852 10 0x0000007855ce39f0 in End (p_input=p_input@entry=0x7863073c00) at ../../src/input/input.c:1413 11 0x0000007855ce0620 in Run (data=0x7863073c00) at ../../src/input/input.c:431 12 0x0000007855d2d5b8 in joinable_thread (data=0x78231b02c0) at ../../src/android/thread.c:96 13 0x0000007953e217c4 in __pthread_start(void) () from /home/tom/work/git/libvlcjni/libvlc/.gdb/obj/local/arm64-v8a/system/lib64/libc.so 14 0x0000007953dc41ac in __start_thread () from /home/tom/work/git/libvlcjni/libvlc/.gdb/obj/local/arm64-v8a/system/lib64/libc.so		3 years ago
..
vlc	libvlc: use the local includes in vlc.h	3 years ago
.gitignore	Ignore the vlc binaries	15 years ago
meson.build	meson: fix named argument style	4 years ago
vlc_access.h	access: set all callback fields in ACCESS_SET_CALLBACKS	4 years ago
vlc_actions.h	actions: shift special keys to make space	5 years ago
vlc_addons.h	Remove stray <vlc_events.h> #include's	6 years ago
vlc_ancillary.h	core: add missing include to vlc_ancillary.h	4 years ago
vlc_aout.h	vlc_aout: add restrict qualifier to match existing callbacks	4 years ago
vlc_aout_volume.h	objects: merge vlc_object_t and vlc_common_members	7 years ago
vlc_arrays.h	remove the $Id$ in the source code	8 years ago
vlc_atomic.h	core: static initializer for refcount	4 years ago
vlc_avcodec.h	Be more precise in libavcodec/libavformat/libavutil separation	13 years ago
vlc_bits.h	vlc_bits: remove bs_remain	6 years ago
vlc_block.h	block: remove BLOCK_FLAG_CLOCK	4 years ago
vlc_block_helper.h	vlc_block_helper: fix offset peek	9 years ago
vlc_boxes.h	vlc_boxes: add bo_size	9 years ago
vlc_charset.h	text: let vlc_towc() return an ssize_t	4 years ago
vlc_clock.h	clock: publicly expose clock's typedefs	4 years ago
vlc_codec.h	gstdecode: add dummy video context and dummy decoder device	4 years ago
vlc_codecs.h	vlc_codecs: assert that our WAVE_FORMAT values match the SDK ones	3 years ago
vlc_common.h	vlc_common: remove redirections to mingw printf functions	4 years ago
vlc_config.h	config: remove unused define	7 years ago
vlc_config_cat.h	prefs: use common defines for all simple pref tab titles & tooltips	5 years ago
vlc_configuration.h	config: use libvlc_int_t directly	4 years ago
vlc_cpu.h	cpu: properly indent x86 defines	3 years ago
vlc_cxx_helpers.hpp	vlc_shared_data_ptr: accept implicit ctor for null	4 years ago
vlc_decoder.h	input_decoder: publicly expose `ChangeDelay`	4 years ago
vlc_demux.h	demux: add more helper methods	3 years ago
vlc_dialog.h	dialogs: split callbacks between interactive and non-interactive callbacks	4 years ago
vlc_diffutil.h	diffutil: provide a generic diffutil implementation	4 years ago
vlc_epg.h	include: fix typos	5 years ago
vlc_es.h	vlc_es: add HDR10+ dynamic metadata	4 years ago
vlc_es_out.h	include: fix typos	5 years ago
vlc_events.h	vlc_events: add event type count define	4 years ago
vlc_executor.h	executor: introduce new executor API	6 years ago
vlc_extensions.h	vlc_extensions: add player reference	4 years ago
vlc_filter.h	filter: constify config_chain_t parameter	6 years ago
vlc_fingerprinter.h	objects: merge vlc_object_t and vlc_common_members	7 years ago
vlc_fixups.h	vlc_fixups: define IN6ADDR_ANY_INIT on OS/2	3 years ago
vlc_fourcc.h	fourcc: add GStreamer Memory opaque chroma	4 years ago
vlc_frame.h	vlc_frame: use a const frame in vlc_frame_ChainProperties	4 years ago
vlc_fs.h	vlc_fs: always map lseek to _lseeki64 on Windows	4 years ago
vlc_gcrypt.h	gcrypt: require libgcrypt >= 1.6.0	11 years ago
vlc_hash.h	src: remove old md5 API	6 years ago
vlc_http.h	Remove old mail address from sources	7 years ago
vlc_httpd.h	remove the $Id$ in the source code	8 years ago
vlc_image.h	image: make the write URL output video format const	8 years ago
vlc_inhibit.h	window: rename vout_window* to vlc_window*	4 years ago
vlc_input.h	input: add a flag for main title	4 years ago
vlc_input_item.h	input: add an option to force preparsing	4 years ago
vlc_interface.h	Add 'amrec' file extension	4 years ago
vlc_interrupt.h	vlc_interrupt: fix doxygen comments	5 years ago
vlc_intf_strings.h	vlc_intf_strings: Rename 'Custom Bookmarks' to 'Bookmarks'	4 years ago
vlc_iso_lang.h	iso639: tweak name-inclusive search algorithm to check names last	5 years ago
vlc_keystore.h	keystore: change vlc_credential_get return type	4 years ago
vlc_list.h	vlc_list: Don't initialize return value with a compound literal in C++	4 years ago
vlc_media_library.h	medialibrary: don't use named intializers in C++	4 years ago
vlc_media_source.h	media tree: make functions public	4 years ago
vlc_memstream.h	memstream: document	7 years ago
vlc_messages.h	vlc_messages: fix documentation referencing vlc_msg_SetCallback()	4 years ago
vlc_meta.h	meta: add vlc_meta_TypeToString()	4 years ago
vlc_meta_fetcher.h	objects: merge vlc_object_t and vlc_common_members	7 years ago
vlc_mime.h	Move mime type guessing by extension to separate file and export it	14 years ago
vlc_modules.h	modules: handle error in module_need_var()	5 years ago
vlc_mouse.h	window: improve documentation	8 years ago
vlc_network.h	vlc_network: define SHUT_xxx values on Windows if they are missing	4 years ago
vlc_objects.h	vlc_objects: add VLC_OBJECT macro for vlc_object_release	4 years ago
vlc_opengl.h	opengl: add an alpha config to the activate cb	3 years ago
vlc_opengl_interop.h	opengl: remove init() callback from interop	4 years ago
vlc_pgpkey.h	include: typo and date fix	14 years ago
vlc_picture.h	vlc_picture: add C++ extern "C"	4 years ago
vlc_picture_fifo.h	include: fix typos	5 years ago
vlc_picture_pool.h	picture_pool: remove picture_pool_Cancel	4 years ago
vlc_player.h	input: update capabilities on end and error	4 years ago
vlc_playlist.h	vlc_playlist: Add FILE_SIZE and FILE_MODIFIED sort keys	4 years ago
vlc_playlist_export.h	objects: merge vlc_object_t and vlc_common_members	7 years ago
vlc_plugin.h	vlc_plugin: add a macro to declare module entries	3 years ago
vlc_probe.h	objects: merge vlc_object_t and vlc_common_members	7 years ago
vlc_queue.h	vlc_queue: fix restrict violation	3 years ago
vlc_rand.h	remove the $Id$ in the source code	8 years ago
vlc_renderer_discovery.h	include: fix typos	5 years ago
vlc_services_discovery.h	include: fix typos	5 years ago
vlc_sort.h	core: add vlc_qsort	8 years ago
vlc_sout.h	sout: expose a light clock API	4 years ago
vlc_spawn.h	vlc_spawn: use unistd.h to get pid_t	4 years ago
vlc_spu.h	include: fix typos	5 years ago
vlc_stream.h	demux: introduce typed operations for demux	3 years ago
vlc_stream_extractor.h	vlc_stream_extractor: doc: capitalize warning	4 years ago
vlc_strings.h	include: fix typos	5 years ago
vlc_subpicture.h	filter: use a specific type for blend filters	7 years ago
vlc_text_style.h	include: fix typos	5 years ago
vlc_threads.h	threads: add vlc_queuedmutex_held()	4 years ago
vlc_thumbnailer.h	thumbnail: rework API to fix use-after-free	4 years ago
vlc_tick.h	vlc_tick: use unsigned for sample frequency	4 years ago
vlc_timestamp_helper.h	vlc_timestamp_helper: fix compilation from C++ modules	4 years ago
vlc_tls.h	vlc_tls: add restrict qualifier to match existing callbacks	4 years ago
vlc_tracer.h	vlc_tracer: fix union target member	4 years ago
vlc_update.h	remove the $Id$ in the source code	8 years ago
vlc_url.h	Improve Doxygen	6 years ago
vlc_variables.h	variables: return size_t with var_CountChoices()	4 years ago
vlc_vector.h	vlc_vector: assert count argument is not 0	4 years ago
vlc_video_splitter.h	window: rename vout_window* to vlc_window*	4 years ago
vlc_viewpoint.h	viewpoint: remove vlc_viewpoint_reverse	6 years ago
vlc_vlm.h	vlm: remove unmaintained (RTSP) VoD support	7 years ago
vlc_vout.h	video_output: remove vout_GetPicture	4 years ago
vlc_vout_display.h	include: don't include vlc_actions.h from vlc_vout_display.h	3 years ago
vlc_vout_osd.h	vlc_vout_osd: move documentation to header	5 years ago
vlc_window.h	window: android: specify the surface id	3 years ago
vlc_xlib.h	LGPL	15 years ago
vlc_xml.h	objects: merge vlc_object_t and vlc_common_members	7 years ago