You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Tree: d7d0bbf8be

3.0.x

cherry-pick-c5513cf9

master

mmdevice-clean/8

update/opus-1.6.1

work/string-cache

work/unnecessary-disc-string

0.1.99e

0.2.70

0.2.72

0.2.73

0.2.81

0.2.83

0.2.91

0.2.92

0.3.0

0.3.1

0.4.0

0.4.1

0.4.2

0.4.3

0.4.4

0.4.5

0.4.6

0.4.6.1

0.5.0

0.5.1

0.5.2

0.5.3

0.6.0

0.6.1

0.6.2

0.7.0

0.7.1

0.7.2

0.8.0

0.8.1

0.8.2

0.8.4

0.9.0

0.9.0-test0

0.9.0-test1

0.9.0-test2

0.9.0-test3

1.0.0-pre1

1.0.0-pre2

1.0.0-rc1

1.1.0-ff

1.1.0-pre1

1.2.0-pre1

1.3.0-git

2.1.0-git

2.2.0-git

3.0.0

3.0.0-1

3.0.0-2

3.0.0-git

3.0.0-rc1

3.0.0-rc2

3.0.0-rc3

3.0.0-rc4

3.0.0-rc5

3.0.0-rc6

3.0.0-rc7

3.0.0-rc8

3.0.0.1

3.0.1

3.0.10

3.0.11

3.0.11.1

3.0.12

3.0.12-1

3.0.12.1

3.0.13

3.0.14

3.0.15

3.0.16

3.0.17

3.0.17-1

3.0.17.2

3.0.17.3

3.0.17.4

3.0.18

3.0.18-rc

3.0.18-rc2

3.0.19

3.0.2

3.0.20

3.0.21

3.0.21-1

3.0.22

3.0.22-rc1

3.0.22-rc2

3.0.23

3.0.23-1

3.0.23-2

3.0.23-test-that-will-be-deleted

3.0.3

3.0.3-1

3.0.4

3.0.5

3.0.5-1

3.0.5-2

3.0.6

3.0.7

3.0.7.1

3.0.7.1-1

3.0.8

3.0.9

3.0.9.1

3.0.9.2

4.0-dev

4.0.0-dev

PA_sk2_2023-0110-195255

PA_sk2_2023-0117-124820

PA_sk2_2023-0322-151238

PA_sk2_2023-0405-102335

PA_sk_master_2021-0701-100025

PA_sk_master_2021-0720-100641

PA_sk_master_2021-0816-183339

PA_sk_master_2021-0906-105147

PA_sk_master_2021-1005-082401

PA_sk_master_2021-1027-100227

PA_sk_master_2021-1102-124600

PA_sk_master_2021-1102-162639

PA_sk_master_2021-1109-022737

PA_sk_master_2022-0303-033453

PA_sk_master_2022-0509-173936

PA_sk_master_2022-0509-191127

PA_sk_master_2022-0510-220720

PA_sk_master_2022-1004-191815

PA_sk_master_2022-1209-200142

PA_vlc_master_2021-0616-164351

audiblegenius-2022-08-12-01

audiblegenius-2022-08-12-02

audiblegenius-2022-08-16-01

audiblegenius-2022-08-16-02

demo-ces2019-vlc-vr

svn-trunk

Branches Tags

${ item.name }

Create tag ${ searchTerm }

Create branch ${ searchTerm }

from 'd7d0bbf8be'

${ noResults }

vlc/modules/gui

History

Sebastian Keller 9724414101 qt: unmap indirection X11 window before reparenting it back to root Reparenting a mapped window to root causes it to become a toplevel window and can cause window managers to reparent the window themselves to show their decorations. This could happen in two situations: 1. Theoretically it could happen briefly between WindowReleased and WindowClose. 2. It could trigger a race between VLC and the WM if there is a quick sequence of WindowOpen -> WindowReleased -> WindowClose -> WindowOpen such as when using single instance mode. If the X-server in this situation happens to re-use the XID of the X11 indirection window from the first WindowOpen for the second WindowOpen, this could result in the following race: - VLC creates a new X11 indirection window, reparents and maps it - VLC reparents it to root - VLC closes the connection, freeing the XID - VLC opens a new connection - VLC creates a new indirection window with the same XID as before and reparents and maps it - The X-server sends a MapRequest for the *first* X11 indirection window caused by the reparent to root to the WM - The WM sees a new toplevel window and reparents it. Because the XID used by that reparent request is the same as of the newly created indirection window, the new window ends up getting reparented. This then would result in the indirection window remaining as toplevel window. The exact order might change slightly between the different processes, but as long as the reparent request by the WM is the last one, the issue will trigger. Closes #25692		4 years ago
..
macosx	macosx: Add missing EXTENSION_WIDGET_PASSWORD handling	4 years ago
minimal_macosx	minimal macosx: Decrease priority for vout window provider	9 years ago
qt	qt: unmap indirection X11 window before reparenting it back to root	4 years ago
skins2	skins2: fix fullscreen wrong size on Windows10 (high DPI)	8 years ago
Makefile.am	macosx: Remove Makefile recursion, change xib compilation	9 years ago
eject.c	Use vlc_close()	10 years ago
ncurses.c	ncurses: fix leak	8 years ago