fd378b2047
packetizer: flac: convert read_utf8 to unsigned
Rationale: this is what the standard implementation (libFLAC) is doing and
there is no need to consider negative samples/frame numbers.
2 years ago
0ddf69fecc
contrib: dvdnav: fix bogus test in patch
Only the cellN values above nr_of_cells + 1 should be rejected,
just as with pgN and nr_of_programs + 1 in the other patch.
2 years ago
3f68114d70
qml: do not use linear filtering effect with non-RHI sg adaptation in ArtistTopBanner
Since blur effect is not available with the non-RHI scene graph adaptation (software,
and openvg adaptations), linear filtering was used here to approximate blur.
However with Qt 6, the texture does not seem to be aligned properly with the software
adaptation. This is most likely a Qt bug, but since the effect is not really important
for non-RHI adaptations, we can instead simply get rid of the effect and lower the
opacity instead.
2 years ago
133b21c235
meson: Bug fix. Define meson variable even when option is disabled.
2 years ago
8da8fb82c6
qt: truncate instead of rounding to the nearest in `onSurfacePositionChanged()`
This is to ensure that video window covers the area where video surface begins.
2 years ago
bb14ebdf89
qt: use `std::ceil()` for video surface size when reporting window size
Quick items have floating point size. Video window size should be ceil
rounded, otherwise bare window may be exposed through slightly larger
`VideoSurface` leading to pixel row/column glitch.
2 years ago
dd31fc7ea1
qml: round the size of `PIPPlayer`
2 years ago
a0d5d9cec6
qml: set fill mode to preserve aspect crop in `NetworkGridItem`
The delegate expects that the image fills the area denoted for
the image.
2 years ago
4847ee6eab
qml: disable filtering child mouse events in Browse page flickable
This fixes pip player can not be dragged properly within the browse
page. Similar to 9b86a3b4
2 years ago
bf5e2572b1
qml: get rid of `firstVisibleItem` and `lastVisibleItem` in `FadingEdgeForListView.qml`
These properties are not reliable.
2 years ago
8af08453c0
qml: introduce `Helpers::itemIntersects(Item, rect)`
2 years ago
5f1d6f6a59
qml: use hover handlers in `FadingEdgeForListView`
This makes it possible to detect hovering better,
as `firstVisibleItem` and `lastVisibleItem` do not
work well at all times.
2 years ago
0c06c384bc
macosx: Make VLCLibraryGroupsViewController VLCLibraryItemPresentingCapable conforming
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2 years ago
db1ef0eeea
macosx: Deduplicate library item presentation procedure in library window
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2 years ago
840affe8cf
macosx: Split application of a segment's relevant view into a different method in library window
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2 years ago
532ed0ff3e
macosx: Add method to get relevant library segment for a given library item
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2 years ago
c6fca27924
macosx: Mark VLCLibraryWindow as VLCLibraryItemPresentingCapable
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2 years ago
a56d39839f
macosx: Mark library view controllers that already implement presentLibraryItem: as VLCLibraryItemPresentingCapable conforming
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2 years ago
659c46e29b
macosx: Add VLCLibraryItemPresentingCapable
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2 years ago
3d0e73a0e9
macosx: Assert correct displaylink init/animation start in playback progress slider cell
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2 years ago
5923be34f4
macosx: Detect bookmark location rename and adjust the bookmark location rather than delete it
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2 years ago
3a03486961
macosx: Observe changes to bookmarked locations and delete bookmark if location is deleted immediately
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2 years ago
65cacb6e7a
macosx: Remove bookmarked locations that no longer exist on load
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2 years ago
4d225c66e6
macosx: Move incrementTrailingNumber into extension method for NSString
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2 years ago
bf60dc5010
macosx: When a notification message is repeated, reset timeout
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2 years ago
358b606062
macosx: Rather than append identical message and duplicating presented messages, just show one message with count
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2 years ago
7326354f5b
macosx: Remove messages if they starts match from status notifier view
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2 years ago
3967e46968
macosx: Add function to add/increment a trailing number counter on a string
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2 years ago
20be0a1a74
macosx: Enable dropping files onto voutview to play them
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2 years ago
91918e91e7
macosx: Inherit from file drag recognising view in VLCVoutView
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2 years ago
3e039431aa
macosx: Use play queue pasteboard handling method from file drag handling view in library window
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2 years ago
85bc3afe13
macosx: Implement standard pasteboard filename handling as playqueue items in file drag recognising view
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2 years ago
feeb4a983a
macosx: Inherit VLCFileDragRecognisingView in VLCDragDropView
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2 years ago
954b5a0799
macosx: Return YES for prepareForDragOperation in file drag recognising view
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2 years ago
4b05dd9741
macosx: Implement performDragOperation in FileDragRecognisingView
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2 years ago
9cbfb04330
macosx: Implement draggingEntered in VLCFileDragRecognisingView
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2 years ago
e3ca629a6c
macosx: Unregister dragged types on file drag recognising view on dealloc
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2 years ago
0f19d94063
macosx: Constify, clean up pasteboard handling method in VLCLibraryWindow
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2 years ago
6d9fcd4ed7
macosx: Set up drag recognition on awake from nib in file drag recognising view
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2 years ago
4f4ecab3ee
macosx: Add inits for VLCFileDragRecognisingView
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2 years ago
ae32aa8dfb
macosx: Add setupDragRecognition method to VLCFileDragRecognisingView
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2 years ago
937f397d96
macosx: Add starter VLCFileDragRecognisingView
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2 years ago
62f11751ed
macos: fix media playback
Given playback was stopped, many issues happened when the playback
was resumed from the main controls bar.
The media time/progress slider wasn't visible anymore and app
crashed unexpectdly when picture in picture was activated.
This was caused by the `_currentMedia` var that was set to `nil`
when playback is stopped but never reassigned when playback was
resumed.
This change will reassign the var with the current played back input
item from the vlc player when the `currentMedia` getter is called.
2 years ago
98bf91e355
macos: fix a notification method signature
The wrong method parameter type was used for the PIP activation
method.
These changes are fixing that.
The notification associated `VLCPlayerController` object is also
used directly in the method implementation instead of accessing it
through a global object.
2 years ago
863a5b8d5b
dvdnav: don't send EOS packet
Not needed since decoders are now drained.
2 years ago
4ae4fe9b24
Revert "decoder: check if draining from IsEmpty()"
This was a temporary commit, to not break bisect while fixing dvdnav.
2 years ago
97a211975d
es_out: remove extra drain call
2 years ago
b67ea0ff9d
es_out: drain from ES_OUT_DRAIN
2 years ago
84e8602496
dvdnav: ensure spus are processed after the last I-frame
SPUs packets might be beyond the final reference frame sectors
(vobu_*ref_ea), causing them to be skipped if we drain the es_out
immediately after the last I-frame. By preferring vobu_ea when it is
nonzero, we ensure SPUs to be properly displayed.
cf. fdb3c73652
2 years ago
48bb67d301
dvdnav: fix DemuxForceStill()
Wait for the es_out to be empty/drained in order to avoid flushing past
video/subtitles.
This also fixes an undefined behavior (that could lead to no audio) when
DemuxForceStill() was called but the PCR was not reset (cf. the other
call to DemuxForceStill() not showing in this diff).
2 years ago
Tristan Matthews
Steve Lhomme
Fatih Uzunoglu
Tal Regev
Claudio Cambra
Maxime Chapelet
Thomas Guillem