The synchro module should not print messages when the quiet-synchro
option is set. To simplify this, add two new helper macros for
debug and warning messages (which currently are the only message
types used in this code) and use those instead of always explicitly
checking the b_quiet variable.
Un-doxygens a lot of doc comments that were already present in the
header file and removes the redundant long descriptions as those are
just prone to get outdated and never updated along with the proper
doc comments in the header.
Change the doc comments for the internal functions to proper
doxygen with the functions marked as internal.
Depending on FLAC_ParseSyncInfo results, the field might get
non-initialized but still assigned. Remove -Wmaybe-uninitialized warning
on Windows.
Signed-off-by: Tristan Matthews <tmatth@videolan.org>
Newer Windows issue this warning if we send metadata with each picture:
DXGI WARNING: IDXGISwapChain4::SetHDRMetaData: Redundant invocation on unchanged
metadata could result in presentation performance inefficiency. [ MISCELLANEOUS WARNING #295: ]
OS/2 socket APIs use int not unsigned int in place of socklen_t. As
a result, compilation is stopped at function call requiring socklen_t *
because of type mismatch between int * and unsigned int *.
Signed-off-by: Steve Lhomme <robux4@ycbcr.xyz>
Mismatching pointers are usually a result of using the incorrect pointer and
might trigger crashes.
Missing initializers are useful for structures of callbacks, to make sure a new
callback is not missing by accident. It's always possible to put NULL, on
purpose, knowingly.
Both flags produce no error on win32/win64 with clang or gcc. But they cannot
be set globally outside of the build script as many contribs will likely fail
these tests and we shouldn't refuse/patch a contrib just for that.
I have been compiling with these flags for weeks without issues. It helped find
some issue (48442d3536) that were pushed
unnoticed without these checks.
Marvin Scholz
Alexandre Janniaux
Steve Lhomme
Francois Cartegnie
KO Myung-Hun
Hugo Beauzée-Luyssen
Quentin Chateau