Given that POSIX does not guarantee the order (nor the number) of the
data-members within "struct iovec", we should either use designated
initializers, or direct member-access, to initialize struct iovec.{iov_base,
iov_len}.
--
See the below:
- http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/sys_uio.h.html
Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>
This adds transitional vlc_tls_ServerSessionCreateFD() helper for
compatiblity. This is only to maintain sequential builds. The helper
will be removed shortly.
Tracks matching the two introduced statements are invalid, but we still played
them fine prior to the refactoring (perhaps intentionally).
In order to stay somewhat back-compatible with earlier versions the two cases
are now added back (since there are actual files in the wild with the invalid
spec).
refs #4250
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
The correct helper-function is named fill_extra_data_alac, and not
fill_extra_data. The errournous usage seems to have been introduced during the
big refactoring of the demuxer.
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
This adds the possibility to build fancy DMGs with background, dmg icon
and special icon positions using the dmgbuild python tool.
If dmgbuild is not available, it will fallback and make a normal DMG.
Setting the no-overwrite flag of the file access output ensures that
record will not indirectly trigger overwriting of an unintended file.
There are two occurences to this problem:
- While probing the muxer format, VLC uses the notoriously insecure and
obsolescent (in POSIX.2008) tempnam() function. This leads to an
arbitrary file overwrite vulnerability via symbolic links.
However, the record plugin really should not need to create temporary
files to probe a muxer format.
- While actually recording content to a permanent file, overwriting an
existing file is not a good idea. This is presumably not a
vulnerability insofar as the output directory belongs to the user.
Regardless, the record plugin should ensure that the output filename
does not already exists (e.g. by creating the file).
So basically, this is a stopgap measure.
The last usage of these functions, TigerConfigurationCallback is the
only one that ever called OnConfigurationChanged, was removed as part
of 231b08e in May 2011.
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
These sections were commented out as part of 86a25b2c1b and
fe3beadd6b (2007-09), and has been unchanged ever since.
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
These changes allow for several cosmetic/functional advantages, such
as:
- automatically expand right-most column to fill entire width
- automatically expand rows to the contents within them
- scroll the table by pixel instead of by row
- remove edit triggers (as these do not have any meaning currently)
fixes#17656
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
Rémi Denis-Courmont
Jean-Baptiste Kempf
Filip Roséen
Marvin Scholz
Doney den Ouden