Music related metadata like album, albumartist, tracknumber and
discnumber is currently not added to media playback messages for
Chromecast.
This patch will add the entries if they're specified in the media
metadata.
Fix -Wreorder warning by moving m_device_name initializer to match
the declaration order in the header file.
In file included from ../modules/stream_out/chromecast/chromecast_ctrl.cpp:34:
../modules/stream_out/chromecast/chromecast.h: In constructor ‘intf_sys_t::intf_sys_t(vlc_object_t*, int, std::string, int, httpd_host_t*)’:
../modules/stream_out/chromecast/chromecast.h:312:13: warning: ‘intf_sys_t::m_pingRetriesLeft’ will be initialized after [-Wreorder]
312 | uint8_t m_pingRetriesLeft;
| ^~~~~~~~~~~~~~~~~
../modules/stream_out/chromecast/chromecast.h:254:20: warning: ‘std::string intf_sys_t::m_device_name’ [-Wreorder]
254 | std::string m_device_name;
| ^~~~~~~~~~~~~
../modules/stream_out/chromecast/chromecast_ctrl.cpp:128:1: warning: when initialized here [-Wreorder]
128 | intf_sys_t::intf_sys_t(vlc_object_t * const p_this, int port, std::string device_addr,
| ^~~~~~~~~~
protoc 3.4.1 reports using libprotoc 3.4.0 instead of 3.4.1.
That's the only release before 3.22 with a minor release version not
reported properly by protoc. After that we get the proper report:
- libprotoc 3.19.5
- libprotoc 3.12.4
- libprotoc 3.6.1
- libprotoc 3.5.1
And before 3.4.1 there were no minor 3.x release versions.
Versions 3.1 to 3.22 are considered to version 1 to 22. 3.22.x then switched to 22.x.
Because it is actually stopping buffering and often used to for that
purpose.
This will be modified to drain after stopping the buffering in a
upcoming commit, since all users also except this behavior.
Mattias Hansson
Nicolas Chauvet
Alexandre Janniaux
KO Myung-Hun
Thomas Guillem
Gautier
Marvin Scholz
Steve Lhomme
Johannes Kauffmann
Alaric Senat
Tristan Matthews