cf. https://developer.apple.com/library/archive/documentation/DeveloperTools/Conceptual/DynamicLibraries/100-Articles/DynamicLibraryUsageGuidelines.html#//apple_ref/doc/uid/TP40001928-SW12
"""
When the library name is a filename (that is, when it doesn’t include
directory names), the dynamic loader searches for the library in several
locations until it finds it, in the following order:
- $LD_LIBRARY_PATH
- $DYLD_LIBRARY_PATH
- The process’s working directory
- $DYLD_FALLBACK_LIBRARY_PATH
When the library name contains at least one directory name, that is,
when the name is a pathname (relative or fully qualified), the dynamic
loader searches for the library in the following order:
- $DYLD_LIBRARY_PATH using the filename
- The given pathname
- $DYLD_FALLBACK_LIBRARY_PATH using the filename
"""
Conclusion: DYLD_LIBRARY_PATH on macOS behave like LD_LIBRARY_PATH on
Linux but LD_LIBRARY_PATH on macOS has a different behavior than
LD_LIBRARY_PATH on Linux, so DYLD_LIBRARY_PATH should be used on macOS.
Specially since we can't really control if the library name will include
a path or not (relative or absolute).
(cherry picked from commit abbe7f3b8b)
Signed-off-by: Marvin Scholz <epirat07@gmail.com>
Avoid this link error:
[ 44%] Linking C executable curltest
Undefined symbols for architecture x86_64:
"_SSLCopyALPNProtocols", referenced from:
_sectransp_connect_step2 in libcmcurl.a(sectransp.c.o)
"_SSLSetALPNProtocols", referenced from:
_sectransp_connect_common in libcmcurl.a(sectransp.c.o)
ld: symbol(s) not found for architecture x86_64
This only happens in the 3.0 macOS CI.
(cherry picked from commit ab126f80d3)
Signed-off-by: Steve Lhomme <robux4@ycbcr.xyz>
(cherry picked from commit eb2ef5d781) (edited)
edited:
- libtool-2.4.6-clang-libs.patch was already merged in this branch
Signed-off-by: Steve Lhomme <robux4@ycbcr.xyz>
This introduces a new fullscreen controller
which uses NSVisualEffectView for it's background
and the icons that are used throughout the rest of
the macOS user interface, hence making it more
consistent with the overall look of VLC.
Additionally the new fullscreen controller is
resizable and, as it already used to be, can be
move around on the screen.
The user interface is now described in a interface
builder file (xib) instead of doing everything in
code. This allows easy usage of autolayout, which
is heavily used to allow adaption of the
buttons/sliders depending on the panel width and
height.
This improves separation between main menu and the unrelated goto
time window.
Besides that, note that each time bindings are used with the file
owner, this owner needs to be an NSWindowController class. Only in
this case retain cycles are avoided (bindings have a strong
reference to the object used).
Thus, this commit helps to properly deinitialize the VLCMain object.
Splits PopupPanel and TextfieldPanel into two xib files and
creates NSWindowController subclasses for each panel.
Each user of the panel gets its own window controller instance.
This is needed as the same kind of window can be shown multiple
times simultaneously (e.g. both in video and audio effects).
This also did not work with the previous implementation of the
2.2 branch and fixes broken behaviour.
Removes sharedInstance from About window controller, and rework
as a NSWindowController subclass. This is the new owner of the xib
and thus instantiated outside the nib bundle.
Splits Help window in own xib and add own NSWindowController as
well.
refs #5556
Alexandre Janniaux
Thomas Guillem
Jean-Baptiste Kempf
Steve Lhomme
Konstantin Pavlov
David Fuhrmann
Rémi Denis-Courmont
Marvin Scholz
Hugo Beauzée-Luyssen
Rafaël Carré
Felix Paul Kühne
Goran Dokic
Ludovic Fauvet