see e967f81f6a.
note, this does **not** affect cat-based module selection items
(of which there are just three in use by the core), since that
mechanism uses subcats not cats.
The config "advanced" flag was unused and has been removed by
6a7a137f7b.
It has been removed from many add_*() macros, but not all. Remove it
from the remaining macros.
If there's one in the process use it. If there's none fallback to
default VLC icon with the old code.
This not only avoids VLC builds depending on GTK, but this should
prevent crashes if GTK 2 is present in the process (e.g. through Qt plugin).
Remove fixed macosx-min-version, as the min version is already
set globally. Fix compilation by ignoring the partial availability
warning. Code is written in a way that it gets disabled on 10.7,
where Growl is still used.
All the NSUser* classes are 10.8; but the rest of the code, using Growl,
should still work in 10.7. The runtime checks seems correct for 10.7.
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
Notify as soon as the current input item is changed,
as it is not a good idea to rely on an item-change
eventually happening later.
This will result in some items that are added and played
immediately lacking metadata in their notifications but
this seems like an acceptable edge case.
Add checks for NSUserNotification and NSUserNotificationCenter so we do not
use them on OS X 10.7 and below, to prevent VLC from crashing if it
is compiled on 10.8 or higher but ran on 10.7 or below.
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
This restores the code that used notifications to determine the app state.
Additionally the inital state is not active, as we get a notification if the
app switches to active after opening.
Signed-off-by: Felix Paul Kühne <fkuehne@videolan.org>
Set an identifier for the VLC Notifications to make
them coalesce when changing tracks rapidly one
after another. (closes#10386)
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
This cleans up unnecessary code which could be replaced by a much simple
check to determine if VLC is in foreground or not.
Add a missing release.
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
This renames the Growl plugin to OS X Notifications to highlight
the new capabilities and to not advertise Growl so much, as
requested.
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
This adds native OS X user notifications as fallback, if Growl is
currently not running. Those native notifications are only available
on 10.8+, therefore some preprocessor conditionals prevent that this
breaks 10.7 compilation.
There is no explicit check if the class is available as it should be
on all 10.8 systems.
Signed-off-by: Felix Paul Kühne <fkuehne@videolan.org>
The input thread sends events. There is no point in checking manually
since the input thread functions aresafe to "use" so long as the caller
has a reference to the input thread (regardless of the input thread
being dead or at EOF). Also the value of those flags can change
asynchronously (outside the input thread) so the checks were racy.
Prevent the es_out from overriding the NowPlaying state by splitting
the meta into NowPlaying and ESNowPlaying.
The function input_item_GetNowPlayingFb can be used to return the
preferred meta value.
Claudio Cambra
Steve Lhomme
Alexandre Janniaux
Lyndon Brown
Romain Vimont
Rémi Denis-Courmont
Emmanuel Nicolet
David Fuhrmann
Felix Paul Kühne
Thomas Guillem
Hugo Beauzée-Luyssen
Marvin Scholz
Alexander Lakhin
Jean-Baptiste Kempf
Avani Sharma
Felix Paul Kühne
Ludovic Fauvet
David Fuhrmann