When multiple pictures are embedded in a file, the FLAC demuxer
prioritizes them based on the picture type.
This ports the same algorithm over so it can be used by Vorbis and Opus.
It also extends its behavior for FLAC to work with both pictures
embedded in VORBIS_COMMENT blocks and in normal PICTURE blocks.
This also plugs a memory leak in vorbis_ParseComment() when parsing
METADATA_BLOCK_PICTURE tags.
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
When there is an ambiguity, the caller is responsible for determining
whether a string is an URL or a path. In most cases, the string is
known as a file path.
This patch also removes support for legacy encodings:
- in taglib, in the non-Windows code paths,
- in the Internationalized Domain Names resolved (only glibc) and
- in the GNOME VFS module.
Support for translation from/to UTF-8 was disabled by default 20 months
ago, and scheduled for removal, 14 months ago.
This fixes some problems when the system or VLC play evil tricks with
the preprocessor. (Only files including sys/stat.h are concerned with
this commit. I did not fix all files.)
Currently, vlc puts the value *and* the description in the value field
for id3 TXXX tags, e.g. in Media Information:
REPLAYGAIN_TRACK_GAIN: REPLAYGAIN_TRACK_GAIN +3.30 dB
This leads to vlc_audio_replay_gain_MergeFromMeta() failing because it
can't parse the floating point value. Since the fieldList() of an
UserTextIdentificationFrame has exactly two members, it is safe to just
use the last (value) member. In Media Information:
REPLAYGAIN_TRACK_GAIN: +3.30 dB
This makes ReplayGain work for mp3 files.
Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>
The preference panel needs to know which of open or save file dialog
it should use. Here we have 27 load and 4 save cases, plus 2 fonts
that were not correctly marked as such in projectM.
Timothy B. Terriberry
Francois Cartegnie
Jean-Baptiste Kempf
Rafaël Carré
Rémi Denis-Courmont
Rémi Duraffort
Angelo Haller
Rafaël Carré
Dominique Leuenberger
Konstantin Pavlov
Johannes Weißl
Fargier Sylvain
Lukáš Lalinský