Fix the following warning:
egrep: warning: egrep is obsolescent; using grep -E
(cherry picked from commit c6ed4170a5)
Signed-off-by: Marvin Scholz <epirat07@gmail.com>
Pos needs to be clamped to the amount of items in the array, else
we might try to insert at an invalid position in the array.
This can happen because the playlist can change till we process the
insertion request, so an item that would have been inserted before at
position 0 is dropped and then we try to insert the next item at
position 1 which would lead to an exception as it is outside the array
bounds.
This is easy to reproduce when using the flattened playlist and dragging
a folder with a few items and a subfolder onto the icon or playlist.
Fix#28660
If token is not found in svg template, psz_template is
freed. Yet it is used in svg_GetDocument as
psz_file_template and incorectly being double freed in
Destroy().
Since the only use of psz_file_template is in svg_GetDocument
and it is performed after a null-check, setting psz_template
to null after freed should fix the issue.
Fixes: #29370 (Coverity 1398436)
(cherry picked from commit 03e511aea8) (rebased)
rebased:
- Replacement of tab with space
The file name should match the app id
Also add OARS metadata, fix default screenshot and fix component type
(cherry picked from commit a66e01306d)
Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>
Conflicts:
configure.ac
po/POTFILES.in
share/.gitignore
share/Makefile.am
share/org.videolan.vlc.appdata.xml.in.in
i_num, which comes from an untrusted source is used as a divisor in
vlc_tick_from_samples.
Fixes: #29369 (Coverity: 1666134)
(cherry picked from commit 5ca90ea1) (rebased)
rebased:
- vlc_tick_from_samples doesn't exist in VLC 3
ParseMetaInfo() will not parse anything in that case as p == p_end.
The image will use the whole of the SPU buffer, potentially containing
metadata at the end. But the reading in RenderImage() is constrained by the width/height
so it won't use these data.
Fixes https://code.videolan.org/videolan/vlc/-/issues/29325
The p_old_map/p_new_map sizes should match their buffer size.
By default the channel counts are zero which considers the old/new maps match.
The channel count read may be updated but not the channel mapping.
We need to check the channel count match and the mapping matches.
Fixes https://code.videolan.org/videolan/vlc/-/issues/29314
We have no other variants of this locale. Adding a country code only
makes the locale more difficult for people to select.
Refs #29383. Manual backport to 3.0.x
Otherwise we end up with warnings like this:
> ld: warning: object file (/Volumes/APFS/Programs/Videolabs/vlc/build/contrib/aarch64-apple-darwin15/lib/libx264.a[63](bitstream-a-8.o)) was built for newer 'macOS' version (15.0) than being linked (11.0)
(cherry picked from commit 47ecb166f3)
Otherwise we end up with warnings like this:
> ld: warning: object file (vlc/build/modules/isa/aarch64/simd/.libs/merge.o) was built for newer 'macOS' version (15.0) than being linked (11.0)
(cherry picked from commit 1e7dc2770d)
It doesn't even compile on Debian unstable at the moment, not even
natively if taken from contribs. Not that there would be any reasons
not to use the build from the distro.
(cherry picked from commit 525ebe9fc3) (rebased)
rebased:
- the code around is slightly different
The error message is printed (among others) when the major versions
differ, not only when the current version is older than the expected
one, so "too old" may be incorrect.
Before:
> meson too old
After:
> meson incompatible version (expected 0.51.1, got 1.1.1)
(cherry picked from commit 8449690b0d)
If the event isn't accepted it is forwarded to the parent widget which also
handles the wheel event. As a result, the if the vout as vertical scrolling used
for seeking, and we scroll vertically on the sound slider, both events would
occur when scrolling on the widget.
When scrolling vertically, angleDelta.x() is 0, so the backward direction was
never accounted for.
We now use wheel converter as it provides better handling of touch pads
this class aggregates wheel events until a full step (120 angle units) is
reached in a direction and emits a synthesized event usable by VLC hotkeys
(cherry picked from commit 7498ac55db without the
QML related methods)
Here is a failure log:
> clang++: error: SDK does not contain 'libarclite' at the path '/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/arc/libarclite_macosx.a'; try increasing the minimum deployment target
>
> contrib-x86_64-apple-darwin18/sparkle/Sparkle.xcodeproj: warning: The macOS deployment target 'MACOSX_DEPLOYMENT_TARGET' is set to 10.7, but the range of supported deployment target versions is 10.13 to 26.0.99.
xcodebuild seems to only be able to support a certain range of
macOS version.
In XCode 26 the minimum supported version seems
to be 10.13 but we need 10.7. However the sparkle/breakpad
builds work when targeting 10.11. growl doesn't build anyway.
The number 26 may differ if an older version is used because iOS, tvOS, etc
had different values than the OSX version before that.
Older XCode versions may have different issues.
Ref. #29414
clang: error: SDK does not contain 'libarclite' at the path '/Volumes/APFS/opt/Xcode15.4.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/arc/libarclite_macosx.a'; try increasing the minimum deployment target
clang: error: SDK does not contain 'libarclite' at the path '/Volumes/APFS/opt/Xcode15.4.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/arc/libarclite_macosx.a'; try increasing the minimum deployment target
ld: file not found: /Volumes/APFS/opt/Xcode14.3.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/arc/libarclite_macosx.a
Steve Lhomme
Alexandre Janniaux
Marvin Scholz
Pierre Lamot
Tristan Matthews
Jean-Baptiste Kempf
Khalid Masum
AsciiWolf
Rémi Denis-Courmont
Stanislav Fort
VideoLAN
François Cartegnie
Romain Vimont