We should not use names stating with underscore for our internal code.
This is almost the same name used in the makefile for more coherence.
HAVE_DYNAMIC_PLUGINS already exists in the core. We keep a different
name to separate the 2 usages. For now they mean exactly the same thing.
x86inc.asm copied from dav1d (8c5d34c85613) and x86util.asm from libav
(994c4bc10751). Libav's LGPL licensed x86util.asm is required for yadif.
This reverts "Remove unused support for .asm files"
commit 6c0f63cd68.
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
MODULE_NAME is only used for static builds:
Here is an example:
for codec/liba52_plugin_la-a52.lo
MODULE_STRING=a52
MODULE_NAME=codec_a52
for packetizer/a52.lo
MODULE_STRING=a52
MODULE_NAME=packetizer_a52
This patch will fix conflicts with the 2 vlc_entry__a52 symbols (that will now
be vlc_entry__codec_a52 and vlc_entry__packetize_a52).
On Android, we used objcopy to rename these symbols, but this tool is not
availaible on iOS toolchain.
By GNU/automake design, those tools have to be present when building
from VCS, even if the generated code is not actually compiled. This
fixes#19086.
Also this potentially allows more than one module to use them.
This reverts commit 76118f5826.
It turns out this is actually an issue with libtool, cleaning the flags
when in link mode and removing the sanitizer flag.
It was fixed in libtool a5c6466528c060cc4660ad0319c00740db0e42ba
but there was no release since this fix.
Using sanitizer and no-undefined will cause linker errors on darwin due
to undefined symbols of the sanitizer.
This is adapted from a patch by Filip Roséen.
In include/vlc_plugin.h, CONCATENATE was failing due to an unexpected '-'
character.
This fixes build with static modules.
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
An ABI change to libvlccore or libcompat will always be signaled by a
change in a header file. That change will trigger a recompilation and
then relinking of affected plugins.
Thus, there is no need for libvlccore.la and libcompat.la to be
explicit dependencies of plugins. This small hack avoids relinking
every plugin whenever the libvlccore is rebuilt.
I don't this abomination to leak through the stable LibVLC interface.
To link statically, modules should be linked into LibVLC instead.
And then, there is no need to reintroduce the old "builtin" vlc-config
type if all modules are built the same. In prehistoric times, the
distinction was needed because some modules were static and some not.
This reverts back to 0.9 (and --enable-libtool 0.8.6) state. This
should fix bindings and web plugins, without hacks. However, this will
require relinking all VLC plugins whenever libvlccore changes.
I kept include files to ../vlc otherwise #include syntax would break
Now, it's up to changing PKGDIR="vlc" to PKGDIR="vlc-1.0".
We just need to decide.
Alexandre Janniaux
Steve Lhomme
Rémi Denis-Courmont
Janne Grunau
Thomas Guillem
Marvin Scholz
Rafaël Carré
Jean-Baptiste Kempf
David Fuhrmann
Luca Barbato
Rafaël Carré
Pierre d'Herbemont
Brad Smith
Rémi Denis-Courmont
Geoffroy Couprie