This is the error we have:
../../../modules/codec/png.c:162:49: warning: '%zu' directive output may be truncated writing between 1 and 20 bytes into a region of size between 18 and 37 [-Wformat-truncation=]
162 | "block size %zu too small for %zu encoded bytes",
| ^~~
../../../modules/codec/png.c:162:19: note: directive argument in the range [1, 18446744073709551615]
162 | "block size %zu too small for %zu encoded bytes",
(cherry picked from commit 59894f24f4)
If the dxva.h file comes from the contribs, it doesn't match the system
__MINGW64_VERSION_MAJOR. But we can detect it another way.
Similar to 20227126ef
This was added in libavcodec 60.26.100 [^1]. We require 58.54.100.
[^1]: 8238bc0b5e
(cherry picked from commit ff292b650e) (edited)
- the vaapi had less profiles
- the direct_va doesn't have HEVC EXT
- FF_PROFILE_UNKNOWN was used in more places
It's not supported in FFMpeg 8.0 since 60.40.100.
It used to be used with preallocated packet buffers with
the old encode API, but said API is no more and therefore
there is no reason for this to be public any more.
So deprecate it and use an internal replacement
for the encoders using it as an upper bound for the
size of their headers.
(cherry picked from commit dae7faa075)
A line: 0% positioning should set the box on top of the video viewport [^1]
(when alignment is top-left which is the default).
Fixes#29230
[^1]: https://www.w3.org/TR/webvtt1/#webvtt-line-cue-setting
(cherry picked from commit 0f215cb3cc)
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
vlc_stream_MemoryNew may return NULL. Which could be dereferenced
by vlc_stream_ReadLine calls in OldEngineClunkyRollInfoPatch.
Fixes: #29363 (Coverity 1666281)
(cherry picked from commit 0b7831694b)
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
ParseMetaInfo() will not parse anything in that case as p == p_end.
The image will use the whole of the SPU buffer, potentially containing
metadata at the end. But the reading in RenderImage() is constrained by the width/height
so it won't use these data.
Fixes https://code.videolan.org/videolan/vlc/-/issues/29325
With malicious files it's possible to overflow the stack.
50 levels of nested tags ought to be enough for anyone.
Fixes#28993.
No ruby support in VLC 3.0 compared to the same patch on VLC 4.0.
sscanf("-1:00:27.500", "%u:%2u:%2u.%3u") returns a large for the negative value.
This happens on Windows and in Linux too [^1].
The returned timestamp is negative (matching what the text says).
That bogus timestamps is then discarded as invalid.
Fixes#28994
[^1]: https://godbolt.org/z/YWEYzPeGq
The assert was there to ensure we don't loop indefinitely on a reduction
that does not happen.
We can check directly if it happened or not.
Fixes#28981
If parsing GOP based captions, the truncate field wasn't being
properly respected, resulting in the last pair being lost if the
flag was set. This would cause intermittent caption bytes to be
missing (e.g. missing characters in rendered captions).
Correct the logic so that the last pair isn't lost, by comparing
the code against the original ccextractor code it was based on.
Tested with "Sports Night", season 1, disc 1.
Signed-off-by: Devin Heitmueller <dheitmueller@ltnglobal.com>
(cherry picked from commit 778d9d254e)
The GOP parser for captions when found in DVD GOPs had an error
when determining the CC count, which excluded the top bit (i.e.
only using the lower four bits of a five bit field). Thus
it would work properly if the cc_count was less than 16, but would
lose the rest of the captions in the GOP.
Parse all five bits of the field.
Signed-off-by: Devin Heitmueller <dheitmueller@ltnglobal.com>
(cherry picked from commit 067b9da0e6)
We don't want to keep the colorimetry of the video.
Until there's a proper spec for HDR colors.
(cherry picked from commit acf3fb486a) (edited)
edited:
- moved the fmt_region init to match 4.0
- adapted the range variable
As found in 9.14.4.2.2.1.1 Semantic definition of fields in PDS
of the Blu-ray specs.
(cherry picked from commit 888438ee92) (edited)
edited:
- in 3.0 the p_sys comes from p_dec
Steve Lhomme
François Cartegnie
Khalid Masum
Tristan Matthews
Stanislav Fort
Thomas Guillem
Devin Heitmueller