This is the only module using them. The option names are retained to
preserve compatibility with existing configuration files and command line
scripts (appending `lua-` would break that).
Check for value of parsed `trusted` property. If the trusted
property is true, the metadata priority is elevated to VLC_META_PRIORITY_PLAYLIST.
If trusted is false, the metadata priority defaults to VLC_META_PRIORITY_BASIC.
Refs #4143
Add function `file_is_playlist` to parse the `trusted` property
of a file. This function will be used to upgrade the metadata
priority from `VLC_META_PRIORITY_BASIC` to `VLC_META_PRIORITY_PLAYLIST`
for files marked as trusted. Set the `trusted` property of CUE files
as they require playlist metadata priority.
Refs #4143
In TRY_META macro, replace input_item_Set##b() with vlc_meta_SetWithPriority().
Rename the TrackNum field to TrackNumber and ArtURL to ArtworkURL for
consistency with the vlc_meta_type_t enumeration.
Refs #4143
see e967f81f6a.
note, this does **not** affect cat-based module selection items
(of which there are just three in use by the core), since that
mechanism uses subcats not cats.
The config "advanced" flag was unused and has been removed by
6a7a137f7b.
It has been removed from many add_*() macros, but not all. Remove it
from the remaining macros.
where identical to shorttext, or near enough.
bad because:
- wastes resources.
- useless tooltips in prefs GUI (poor UX) - tooltip longtext should add
something of value.
- useless repetition of text in certain help output.
in some cases they differed only in full-stop, creating unnecessary extra
burden on translators.
This increases the priority of every stream filter with non-zero
priority by 300. The point is to make those priorities higher than any
existing demux priority (to merge the two capabilities later on).
Playlist lua modules are probed for each opened input. This can take a lot of
time, it can double the time of a local parsing where no lua module are needed.
This time is negligible when playing a file.
Playlist lua probe can take 5ms on desktop (in comparison of 5ms for parsing),
or 50ms on some android devices.
This new option can be used by VLC ports to disable lua when using VLC for
parsing.
As we are only checking whether the dictionary has a certain key (to
prevent loading the same thing twice), vlc_dictionary_has_key is
semantically more correct than vlc_dictionary_value_for_key.
Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>
This splits vlclua_playlist_add_internal() in two functions. The new
function parses a single input item from a Lua script.
This also adds handling for a few error cases.
The function does not open MRLs, as correctly described in its
documentation, as such it is rather unfortunate that its name uses MRL
instead of URL (especially given that it cannot handle MRLs).
These changes are simply renaming all occurrences of the function, so
that the behavior of the function is properly reflected by its name.
Signed-off-by: Thomas Guillem <thomas@gllm.fr>
This removes the insertion offset parameter to playlist_Add(),
playlist_AddExt() and playlist_AddInput().
intf_InsertItem() was the only occurrence where the offset was zero,
a side effect of how the command line is parsed backward. This is now
done explicitly with playlist_NodeAddInput().
A non-zero positive offset made no sense, since:
- the number of children of a node can change asynchronously while the
playlist lock,
- the back-end asserted or triggered undefined behaviour if the offset
was out of range.
DBus was the only occurrence of this bug (see also #17451 comment:4),
and has been fixed in an earlier change.
In all remaining call sites, the offset was PLAYLIST_END. This removes
the parameter which would otherwise constitute a useless constant.
They are set but never used. In practice, the (following) position
parameter determines whether the item is inserted or appended. A
positive position means insertion; PLAYLIST_END means appendment.
vlc_dictionary_all_keys requires the caller to not only release the
returned value, but also the entities this value refers to; these
changes fixes a memory-leak due to not doing the latter.
Signed-off-by: Pierre Ynard <linkfanel@yahoo.fr>
Rémi Denis-Courmont
Ayush Dey
Hank Anderson
Steve Lhomme
Johannes Kauffmann
Thomas Guillem
Alexandre Janniaux
Lyndon Brown
Romain Vimont
Hannes Domani
Hugo Beauzée-Luyssen
Filip Roséen
Jean-Baptiste Kempf
Pierre Ynard