Thomas Guillem
d1ca10c62b
mms: fix potential integer overflow
That could lead to a heap buffer overflow.
Thanks Andreas Fobian for the report.
3 years ago
Thomas Guillem
de2f34e778
mms: return -1 in case of error
The function calling mms_ParsePacket() is expecting -1 (for error) or a
valid positive integer for success.
3 years ago
Thomas Guillem
16dbe955d6
mms: decrease i_packet_length in only one place
3 years ago
Thomas Guillem
8724a30294
mms: use const in mms_ParsePacket()
3 years ago
Steve Lhomme
40c52097c8
imem: return proper demuxer return codes
3 years ago
Johannes Kauffmann
968680321d
cdda: don't check for !*psz_mbserver
The current code looks like it leaks. It doesn't, because checking for
!*psz_mbserver (and free()ing it) is done for us by var_InheritString.
3 years ago
Johannes Kauffmann
b945194f17
access/dtv: fix mod leak
3 years ago
Marvin Scholz
d0c5c9c3af
access: ftp: avoid using sprintf
Use snprintf to avoid a deprecation warning about sprintf on Darwin platforms.
3 years ago
Marvin Scholz
b93f201c75
http: avoid using sprintf
Use snprintf to avoid a deprecation warning about sprintf on Darwin platforms.
3 years ago
Marvin Scholz
8fba6c29bc
access: cdda: avoid using sprintf
Use snprintf to avoid a deprecation warning about sprintf on Darwin platforms.
3 years ago
Johannes Kauffmann
4aa0c2f3f4
modules: add missing void parameters to functions
Caught by -Wstrict-prototypes.
3 years ago
Rémi Denis-Courmont
dc384d52b9
wasapi: use stdc_count_ones()
3 years ago
Rémi Denis-Courmont
cbfd849fda
rtp/pcm: use stdc_count_ones()
3 years ago
Rémi Denis-Courmont
2ab31af00a
rtp/mp2v: use stdc_trailing_zeros()
3 years ago
Rémi Denis-Courmont
12c21a94a9
dtv: use stdc_trailing_zeros()
3 years ago
Rémi Denis-Courmont
6dccabda26
jack: use stdc_bit_floor()
3 years ago
Thomas Guillem
71f54c2557
dcp: add (future) missing include
vlc_events.h will be removed.
vlc_events.h, that is included by vlc_input_item.h, includes vlc_arrays.h
3 years ago
Thomas Guillem
3a68cbb3e5
dshow: add (future) missing include
vlc_events.h will be removed.
vlc_events.h, that is included by vlc_input_item.h, includes vlc_arrays.h
3 years ago
Steve Lhomme
c31160afb7
dshow: don't create local variable for chroma
We never use that variable afterwards.
3 years ago
Steve Lhomme
8327d88805
wasapi: don't define CONST_VTABLE when we don't need it
We're not create a COM object in C.
3 years ago
Steve Lhomme
e52cc89f80
modules: set VLC_MALLOC on strings allocated by a memstream
After vlc_memstream_close() the memstream cannot be used anymore.
3 years ago
Steve Lhomme
27be18daf2
subpicture: don't preemptively call video_format_IsSimilar to update SPU's
The callee may not care at all and we're doing many tests for nothing.
3 years ago
Alexandre Janniaux
6e6018815c
bluray: use new spu updater operation
3 years ago
Alexandre Janniaux
a987b446af
vlc_subpicture: rename p_sys to sys
Uniformize the subpicture updater structure with the rest of the new
code, by removing the hungarian notation. The operations will also be
updated later with the introduction of a dedicated operation table.
3 years ago
Steve Lhomme
844deb7121
bluray: fix overlay status when there's no region left
Otherwise it remains perpetually to Outdated.
If p_overlay->regions is empty then no copy will be done and
p_subpic->regions will remain empty.
3 years ago
Steve Lhomme
2345f09ed2
bluray: merge subpictureUpdaterValidate into subpictureUpdaterUpdate
3 years ago
Steve Lhomme
2f054d8f6d
bluray: return proper error codes in subpictureUpdaterValidate()
3 years ago
Steve Lhomme
2fcc517952
subpicture: merge pf_validate and pf_update calls
pf_validate is supposed to tell if the regions need to be redone or not.
But since pf_update is going to write the regions, it can also reset the
container by itself. It's the owner of these regions.
3 years ago
Steve Lhomme
0ee8e70d9a
bluray: use a reference of internal pictures instead of picture copy
The picture inside our internal regions is refcounted, so it will stay alive
even if the internal region is deleted.
This will make things a bit faster and use less memory.
3 years ago
Jean-Baptiste Kempf
df6394ea80
SRT: remove tabs in source code
3 years ago
Steve Lhomme
d6ffd5bc35
subpicture: use helper functions for vlc_spu_regions
3 years ago
Steve Lhomme
72f948ca52
subpicture: rename subpicture_region_ChainDelete() to vlc_spu_regions_Clear()
3 years ago
Steve Lhomme
3d610be9f0
subpicture: use vlc_list for regions
This separates the region type from its container.
The drawback is that it makes the structure bigger. But we get plenty
of helpers. There might be other containers suitable but we use a mix of
append and prepend.
3 years ago
Steve Lhomme
143e0125dd
bluray: return early if the region creation fails
3 years ago
Thomas Guillem
f7f346e686
mmsh: check user size bounds
3 years ago
Steve Lhomme
04d3c31333
screen/wayland: init all known fields to NULL
Fixes a missing initializer warnings. This is similar to how it's done
for wl_pointer_listener.
3 years ago
Steve Lhomme
a642f638e8
decklink: split the code to log field dominance and map to block flags
3 years ago
Steve Lhomme
3164c8970a
decklink: don't return a whole es_format_t
And return an error when we can't use a format. We shouldn't pretend
everything is OK.
3 years ago
Steve Lhomme
47af51ec58
vlc_es: remove always 0 video_format_t RGB mask
3 years ago
Steve Lhomme
a4280d3493
vlc_es: remove empty video_format_FixRgb()
3 years ago
Steve Lhomme
eb14275ab3
screen/xcb: replace VLC_CODEC_RGB15 with RGB555
This is the format once the mask will be " fixed" depending on endianness.
3 years ago
Steve Lhomme
a0670492db
screen/xcb: replace VLC_CODEC_RGB16 with VLC_CODEC_RGB565
This is the format once the mask will be " fixed" depending on endianness.
3 years ago
Steve Lhomme
622a5812e3
access/shm: use default 15-bit/16-bit chroma without a mask
These correspond to the format with the "fixed" mask depending on endianness.
SHM was always using the native endianness and the default masks for each
bit depth.
3 years ago
Steve Lhomme
68554e484c
access/vnc: use RGB565LE/BE for 16-bit/default depth
This corresponds to the mask given to the client, depending on endianness.
3 years ago
Steve Lhomme
8c98fc91e0
access/rdp: fail if gdi_init() fails
3 years ago
Steve Lhomme
1674af4837
access/rdp: map the format to known chromas
According to the color definitions in [1]. And the naming matches the memory
order:
> The format naming scheme is based on byte position in memory.
Given it's a Windows protocol the 15/16-bit variants are assumed to be
Little-Endian.
The pixel formats should be the one we set in postConnectHandler,
but we map all of them just in case.
[1} b608be19e4/include/freerdp/codec/color.h
3 years ago
Steve Lhomme
3af18cdaa9
screen/xcb: replace VLC_CODEC_RGB24M with VLC_CODEC_RGB24
This is the format once the mask will be "fixed".
3 years ago
Steve Lhomme
3b728b54f2
win32: really fix the DllMain signature
After 9ca790a641 the DWORD turned into
an unsigned, but it should be an unsigned long.
3 years ago
Steve Lhomme
91bde00c81
access/v4l2: remove always null mask
3 years ago
Steve Lhomme
b111d3b31b
dxgi_fmt: remove empty DxgiFormatMask()
3 years ago