If there's an error, the value we set is not actually set. Maybe an old value
is still in there or the variable is gone or something else is blocking.
We can't use the new value in the future and we don't know if the old value is
still in there.
This used one too many derefs, and then due to the earlier write of null
near the beginning of the function (making a null write here redundant)
there was thus a null-deref.
Regression from 0e9db4f7e6.
The DXGI code is always compiled on Windows as it's only using calls available
since Windows 7, although IDXGIOutputDuplication will not be available.
The block_t sent contains a D3D11-based picture_t that can be used without
any additional copy using the shared handle.
If anyone has a pthread with a different Windows SDK it should work.
It will also avoid bogus pthread.h missing reports when mingw-w64 is not
detected properly. HAVE_WINPTHREAD is not checked and assumed to be
available.
This fixes the bad option default for this value. The default being
`VPX_DL_GOOD_QUALITY`, which is defined as `1000000` not `0` as seemed to be
the author's assumption, did not map to the specified range of 0-2 and thus
was getting clamped to 2, corresponding to 'best' quality rather than 'good'
quality.
It was requested in review to map the option values to match the vpx defines
rather than simply change the default value to `0`. This necessitates
removal of the range.
This was placed into the same grid row+column as a spinbox and thus
achieved absolutely nothing. Presumably it was intended for the adjacent
column, however since it achieves nothing either way let's just drop it.
Viewing the ui files in Qt creator revealed excess empty space at the
bottom of some, a huge amount in the case of media-library. This ultimately
has no impact upon the final result, but I thought I'd fix it for neatness.
Note that these numbers were the product of simply dragging the canvas size
until it snapped into place.
Such that the effect is thus visible in Qt Creator/Designer.
The compatibility note is obviously obsolete now, but presumably we still
want this style anyway since its read-only.
Steve Lhomme
Lyndon Brown
Benjamin Arnaud
xqq
Rémi Denis-Courmont
Prince Gupta
Juliane de Sartiges
Jean-Baptiste Kempf