Within all the introduced static libraries, the module cannot be known
at compilation time. This moves the module name from a compilation
constant to a link time constant string symbol. That way, the same
compiled object within a static library can use a different and correct
module name depending on which plugin it is linked into.
The symbol is hidden so it does not leak between shared objects. For
non-plugins shared libraries (vlccore, vlc, vlc_pulse and
vlc_xcb_events) the module name must be defined manually, unless the
library does not use msg_* macros at all (vlc_vdpau).
This reverts commit 76118f5826.
It turns out this is actually an issue with libtool, cleaning the flags
when in link mode and removing the sanitizer flag.
It was fixed in libtool a5c6466528c060cc4660ad0319c00740db0e42ba
but there was no release since this fix.
Using sanitizer and no-undefined will cause linker errors on darwin due
to undefined symbols of the sanitizer.
This is adapted from a patch by Filip Roséen.
Otherwise, it gets executed with /bin/sh which on Solaris does not support the
$(...) construct. This causes 'gmake check' to fail. For example:
../src/check_headers: $(dirname ../src/check_headers): does not exist
Calling check_headers with $(SHELL) explicitly makes use of CONFIG_SHELL.
Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>
Rémi Denis-Courmont
Marvin Scholz
Thomas Guillem
Rafaël Carré
Jean-Baptiste Kempf
KO Myung-Hun
Maciej Blizinski
Pierre Ynard
Rémi Denis-Courmont
Sam Hocevar