...unless they were forced to relative locally.
decoder_NewSubpicture() calls spu.buffer_new which always calls subpicture_New().
And subpicture_New() sets subpictures are absolute by default.
var_InheritString() guarantees that, if the string returned is not NULL,
the string does not contain a NULL terminator as first character.
Checking for strlen() > 0 does the same as checking if the string
contains a NULL terminator as first character, because strlen() doesn't
count the NULL terminator. Thus, remove the unneeded check.
Uniformize the subpicture updater structure with the rest of the new
code, by removing the hungarian notation. The operations will also be
updated later with the introduction of a dedicated operation table.
pf_validate is supposed to tell if the regions need to be redone or not.
But since pf_update is going to write the regions, it can also reset the
container by itself. It's the owner of these regions.
This separates the region type from its container.
The drawback is that it makes the structure bigger. But we get plenty
of helpers. There might be other containers suitable but we use a mix of
append and prepend.
The original format may be using a chroma that relies on the RGB masks.
Since we change the chroma we should not reuse the mask from the previous
chroma.
We don't need to know it's a pointer and can save 2 characters.
No functional changes. This is simply renaming "dec->p_fmt_in",
"decoder->p_fmt_in", "dec.p_fmt_in" and "packetizer->p_fmt_in"