Browse Source

contrib: upnp: disable webserver and device handling

VLC 3.0 uses libupnp exclusively as a client. LibUpnp internals are
quite opaque and it has been observed that a webserver thread is still
running on idle with open sockets even if the library is used as a
client only.

The recent bump to 1.14 introduces regressions in libupnp's webserver
socket initialization [1] on windows. Since the bug is still not
corrected upstream and we don't have any use of the webserver for 3.0
anyway, let's just disable it.

[1] https://github.com/pupnp/pupnp/issues/195

Fixes videolan/vlc#27001
cherry-pick-c5513cf9
Alaric Senat 4 years ago
committed by Steve Lhomme
parent
commit
e0a99d6364
  1. 2
      contrib/src/upnp/rules.mak

2
contrib/src/upnp/rules.mak

@ -16,7 +16,7 @@ $(TARBALLS)/pupnp-release-$(UPNP_VERSION).tar.gz:
UPNP_CFLAGS := $(CFLAGS) -DUPNP_STATIC_LIB UPNP_CFLAGS := $(CFLAGS) -DUPNP_STATIC_LIB
UPNP_CXXFLAGS := $(CXXFLAGS) -DUPNP_STATIC_LIB UPNP_CXXFLAGS := $(CXXFLAGS) -DUPNP_STATIC_LIB
UPNP_CONF := --disable-samples UPNP_CONF := --disable-samples --disable-device --disable-webserver
ifdef HAVE_WIN32 ifdef HAVE_WIN32
DEPS_upnp += pthreads $(DEPS_pthreads) DEPS_upnp += pthreads $(DEPS_pthreads)

Loading…
Cancel
Save