qml: disable section change buttons in `MusicArtist`

Currently it does not work reliably, even though theoretically it should work fine. This is possibly about `contentHeight` not being calculated by the view when sections are used, rather than the logic we have at the moment for changing the section. Until a workaround is found, this patch disables the sections buttons.
6 months ago · 8996a4ede7
2 changed files with 42 additions and 42 deletions
--- a/modules/gui/qt/medialibrary/qml/MusicAlbumSectionDelegate.qml
+++ b/modules/gui/qt/medialibrary/qml/MusicAlbumSectionDelegate.qml
@ -355,45 +355,45 @@ T.Pane {
                    showText: !_contentItem.compactDownButtons

                    Navigation.parentItem: root
-                    Navigation.rightItem: previousSectionButton.enabled ? previousSectionButton
-                                                                        : nextSectionButton
+                    // Navigation.rightItem: previousSectionButton.enabled ? previousSectionButton
+                    //                                                     : nextSectionButton
                    Navigation.leftItem: playButton
                }
            }
        }

-        Column {
-            Layout.alignment: Qt.AlignVCenter
+        // Column {
+        //     Layout.alignment: Qt.AlignVCenter

-            spacing: VLCStyle.margin_small
+        //     spacing: VLCStyle.margin_small

-            PreviousSectionButton {
-                id: previousSectionButton
+        //     PreviousSectionButton {
+        //         id: previousSectionButton

-                delegate: root
+        //         delegate: root

-                activeFocusOnTab: false
+        //         activeFocusOnTab: false

-                showText: !_contentItem.compactRightButtons
+        //         showText: !_contentItem.compactRightButtons

-                Navigation.parentItem: root
-                Navigation.downItem: nextSectionButton
-                Navigation.leftItem: enqueueButton
-            }
+        //         Navigation.parentItem: root
+        //         Navigation.downItem: nextSectionButton
+        //         Navigation.leftItem: enqueueButton
+        //     }

-            NextSectionButton {
-                id: nextSectionButton
+        //     NextSectionButton {
+        //         id: nextSectionButton

-                delegate: root
+        //         delegate: root

-                activeFocusOnTab: false
+        //         activeFocusOnTab: false

-                showText: !_contentItem.compactRightButtons
+        //         showText: !_contentItem.compactRightButtons

-                Navigation.parentItem: root
-                Navigation.upItem: previousSectionButton
-                Navigation.leftItem: enqueueButton
-            }
-        }
+        //         Navigation.parentItem: root
+        //         Navigation.upItem: previousSectionButton
+        //         Navigation.leftItem: enqueueButton
+        //     }
+        // }
    }
 }
--- a/modules/gui/qt/medialibrary/qml/MusicArtist.qml
+++ b/modules/gui/qt/medialibrary/qml/MusicArtist.qml
@ -291,36 +291,36 @@ FocusScope {
                            showText: !_contentItem.compactButtons

                            Navigation.parentItem: pinnedMusicAlbumSection
-                            Navigation.rightItem: previousSectionButton
+                            // Navigation.rightItem: previousSectionButton
                            Navigation.leftItem: playButton
                        }

-                        MusicAlbumSectionDelegate.PreviousSectionButton {
-                            id: previousSectionButton
+                        // MusicAlbumSectionDelegate.PreviousSectionButton {
+                        //     id: previousSectionButton

-                            delegate: pinnedMusicAlbumSection
+                        //     delegate: pinnedMusicAlbumSection

-                            visible: _contentItem.displayPositioningButtons
+                        //     visible: _contentItem.displayPositioningButtons

-                            showText: !_contentItem.compactButtons
+                        //     showText: !_contentItem.compactButtons

-                            Navigation.parentItem: pinnedMusicAlbumSection
-                            Navigation.rightItem: nextSectionButton
-                            Navigation.leftItem: enqueueButton
-                        }
+                        //     Navigation.parentItem: pinnedMusicAlbumSection
+                        //     Navigation.rightItem: nextSectionButton
+                        //     Navigation.leftItem: enqueueButton
+                        // }

-                        MusicAlbumSectionDelegate.NextSectionButton {
-                            id: nextSectionButton
+                        // MusicAlbumSectionDelegate.NextSectionButton {
+                        //     id: nextSectionButton

-                            delegate: pinnedMusicAlbumSection
+                        //     delegate: pinnedMusicAlbumSection

-                            visible: _contentItem.displayPositioningButtons
+                        //     visible: _contentItem.displayPositioningButtons

-                            showText: !_contentItem.compactButtons
+                        //     showText: !_contentItem.compactButtons

-                            Navigation.parentItem: pinnedMusicAlbumSection
-                            Navigation.leftItem: previousSectionButton
-                        }
+                        //     Navigation.parentItem: pinnedMusicAlbumSection
+                        //     Navigation.leftItem: previousSectionButton
+                        // }
                    }

                    Navigation.parentItem: root