modules: avcodec: remove avcodec-workaround-bugs option

This is an incredibly advanced per-media option that is probably more
confusing for users than it does any good. The values are not even
exposed properly, just some of them written in the help text.

If someone really needs this, it can already be set by
--avcodec-options "{bug=...}", so having a dedicated VLC option
that doesn't add any convenience to it is redundant.

modules/codec/avcodec/avcodec.c

@@ -108,7 +108,7 @@ vlc_module_begin ()
     add_bool( "avcodec-corrupted", true, CORRUPTED_TEXT, CORRUPTED_LONGTEXT )
     add_integer ( "avcodec-error-resilience", 1, ERROR_TEXT,
         ERROR_LONGTEXT )
-    add_integer ( "avcodec-workaround-bugs", 1, BUGS_TEXT, BUGS_LONGTEXT )
+    add_obsolete_integer ( "avcodec-workaround-bugs" ) /* removed since 4.0.0 */
     add_bool( "avcodec-hurry-up", true, HURRYUP_TEXT, HURRYUP_LONGTEXT )
     add_integer( "avcodec-skip-frame", 0, SKIP_FRAME_TEXT,
         SKIP_FRAME_LONGTEXT )

modules/codec/avcodec/avcodec.h

@@ -66,19 +66,6 @@ int ffmpeg_OpenCodec( decoder_t *p_dec, AVCodecContext *, const AVCodec * );
     "this can produce a lot of errors.\n" \
     "Valid values range from 0 to 4 (0 disables all errors resilience).")
 
-#define BUGS_TEXT N_("Workaround bugs")
-#define BUGS_LONGTEXT N_( \
-    "Try to fix some bugs:\n" \
-    "1  autodetect\n" \
-    "2  old msmpeg4\n" \
-    "4  xvid interlaced\n" \
-    "8  ump4 \n" \
-    "16 no padding\n" \
-    "32 ac vlc\n" \
-    "64 Qpel chroma.\n" \
-    "This must be the sum of the values. For example, to fix \"ac vlc\" and " \
-    "\"ump4\", enter 40.")
-
 #define HURRYUP_TEXT N_("Hurry up")
 #define HURRYUP_LONGTEXT N_( \
     "The decoder can partially decode or skip frame(s) " \

modules/codec/avcodec/video.c

@@ -549,8 +549,6 @@ static int InitVideoDecCommon( decoder_t *p_dec )
                                 p_dec->fmt_in->i_original_fourcc : p_dec->fmt_in->i_codec );
 
     /*  ***** Get configuration of ffmpeg plugin ***** */
-    p_context->workaround_bugs =
-        var_InheritInteger( p_dec, "avcodec-workaround-bugs" );
     p_context->err_recognition =
         var_InheritInteger( p_dec, "avcodec-error-resilience" );