Remove change_unsafe() no-op.

include/vlc_plugin.h

@@ -445,8 +445,6 @@ enum vlc_config_properties
 #define change_unsaveable() \
     vlc_config_set (p_config, VLC_CONFIG_VOLATILE);
 
-#define change_unsafe() (void)0; /* no-op */
-
 #define change_safe() \
     vlc_config_set (p_config, VLC_CONFIG_SAFE);
 

modules/access_filter/timeshift.c

@@ -73,7 +73,6 @@ vlc_module_begin();
     add_integer( "timeshift-granularity", 50, NULL, GRANULARITY_TEXT,
                  GRANULARITY_LONGTEXT, true );
     add_directory( "timeshift-dir", 0, 0, DIR_TEXT, DIR_LONGTEXT, false );
-        change_unsafe();
     add_bool( "timeshift-force", false, NULL, FORCE_TEXT, FORCE_LONGTEXT,
               false );
 vlc_module_end();

modules/audio_output/file.c

@@ -122,7 +122,6 @@ vlc_module_begin();
                  CHANNELS_TEXT, CHANNELS_LONGTEXT, true );
     add_file( "audiofile-file", "audiofile.wav", NULL, FILE_TEXT,
               FILE_LONGTEXT, false );
-        change_unsafe();
     add_bool( "audiofile-wav", 1, NULL, WAV_TEXT, WAV_LONGTEXT, true );
 
     set_capability( "audio output", 0 );

modules/demux/demuxdump.c

@@ -57,7 +57,6 @@ vlc_module_begin();
     set_capability( "demux", 0 );
     add_file( "demuxdump-file", "stream-demux.dump", NULL, FILE_TEXT,
               FILE_LONGTEXT, false );
-        change_unsafe();
     add_bool( "demuxdump-append", 0, NULL, APPEND_TEXT, APPEND_LONGTEXT,
               false );
     set_callbacks( Open, Close );

modules/demux/ts.c

@@ -172,7 +172,6 @@ vlc_module_begin();
     add_bool( "ts-silent", 0, NULL, SILENT_TEXT, SILENT_LONGTEXT, true );
 
     add_file( "ts-dump-file", NULL, NULL, TSDUMP_TEXT, TSDUMP_LONGTEXT, false );
-        change_unsafe();
     add_bool( "ts-dump-append", 0, NULL, APPEND_TEXT, APPEND_LONGTEXT, false );
     add_integer( "ts-dump-size", 16384, NULL, DUMPSIZE_TEXT,
                  DUMPSIZE_LONGTEXT, true );

modules/misc/logger.c

@@ -141,7 +141,6 @@ vlc_module_begin();
 
     add_file( "logfile", NULL, NULL,
              N_("Log filename"), N_("Specify the log filename."), false );
-        change_unsafe();
     add_string( "logmode", "text", NULL, LOGMODE_TEXT, LOGMODE_LONGTEXT,
                 false );
         change_string_list( mode_list, mode_list_text, 0 );

modules/stream_out/es.c

@@ -89,7 +89,6 @@ vlc_module_begin();
                 MUX_LONGTEXT, true );
     add_string( SOUT_CFG_PREFIX "dst", "", NULL, DEST_TEXT,
                 DEST_LONGTEXT, true );
-        change_unsafe();
 
     set_section( N_("Audio"), NULL );
     add_string( SOUT_CFG_PREFIX "access-audio", "", NULL, ACCESSA_TEXT,
@@ -98,7 +97,6 @@ vlc_module_begin();
                 MUXA_LONGTEXT, true );
     add_string( SOUT_CFG_PREFIX "dst-audio", "", NULL, DESTA_TEXT,
                 DESTA_LONGTEXT, true );
-        change_unsafe();
 
     set_section( N_("Video"), NULL );
     add_string( SOUT_CFG_PREFIX "access-video", "", NULL, ACCESSV_TEXT,
@@ -107,7 +105,6 @@ vlc_module_begin();
                 MUXV_LONGTEXT, true );
     add_string( SOUT_CFG_PREFIX "dst-video", "", NULL, DESTV_TEXT,
                 DESTV_LONGTEXT, true );
-        change_unsafe();
 
     set_callbacks( Open, Close );
 vlc_module_end();

modules/stream_out/rtp.c

@@ -167,7 +167,6 @@ vlc_module_begin();
 
     add_string( SOUT_CFG_PREFIX "dst", "", NULL, DEST_TEXT,
                 DEST_LONGTEXT, true );
-        change_unsafe();
     add_string( SOUT_CFG_PREFIX "sdp", "", NULL, SDP_TEXT,
                 SDP_LONGTEXT, true );
     add_string( SOUT_CFG_PREFIX "mux", "", NULL, MUX_TEXT,

modules/stream_out/standard.c

@@ -115,7 +115,6 @@ vlc_module_begin();
                 BIND_LONGTEXT, false );
     add_string( SOUT_CFG_PREFIX "path", "", NULL, PATH_TEXT,
                 PATH_LONGTEXT, false );
-        change_unsafe();
 
     add_bool( SOUT_CFG_PREFIX "sap", false, NULL, SAP_TEXT, SAP_LONGTEXT,
               true );

src/libvlc-module.c

@@ -1551,7 +1551,6 @@ vlc_module_begin();
     set_section( N_("Snapshot") , NULL );
     add_directory( "snapshot-path", NULL, NULL, SNAP_PATH_TEXT,
                    SNAP_PATH_LONGTEXT, false );
-        change_unsafe();
     add_string( "snapshot-prefix", "vlcsnap-", NULL, SNAP_PREFIX_TEXT,
                    SNAP_PREFIX_LONGTEXT, false );
     add_string( "snapshot-format", "png", NULL, SNAP_FORMAT_TEXT,
@@ -1877,7 +1876,6 @@ vlc_module_begin();
     add_directory( "plugin-path", NULL, NULL, PLUGIN_PATH_TEXT,
                    PLUGIN_PATH_LONGTEXT, true );
         change_need_restart();
-        change_unsafe();
 
     set_section( N_("Performance options"), NULL );
     add_bool( "minimize-threads", 0, NULL, MINIMIZE_THREADS_TEXT,