From 69ee998d3c9fe363b1af52ba3ee20fcd2c0a8b0f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=A9mi=20Duraffort?= Date: Sun, 4 Mar 2012 19:25:32 +0100 Subject: [PATCH] http: fix memory leak in the error path --- modules/access/http.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/modules/access/http.c b/modules/access/http.c index cc1ec8227d..a292ebb9fd 100644 --- a/modules/access/http.c +++ b/modules/access/http.c @@ -917,13 +917,11 @@ static int ReadICYMeta( access_t *p_access ) for( i_read = 0; i_read < i_size; ) { int i_tmp; - if( ReadData( p_access, &i_tmp, (uint8_t *)&psz_meta[i_read], i_size - i_read ) ) + if( ReadData( p_access, &i_tmp, (uint8_t *)&psz_meta[i_read], i_size - i_read ) || i_tmp <= 0 ) { free( psz_meta ); return VLC_EGENERIC; } - if( i_tmp <= 0 ) - return VLC_EGENERIC; i_read += i_tmp; } psz_meta[i_read] = '\0'; /* Just in case */