From 63dd4d49e4449202d21c769fc3ada7f5b60b3433 Mon Sep 17 00:00:00 2001 From: Steve Lhomme Date: Thu, 5 Feb 2026 14:28:26 +0100 Subject: [PATCH] preparser: never call the external preparser on unsupported platforms And log an error in an external processing is requested on an unsupported platform. We fallback to internal processing. Otherwise the preparsing will always fail. And this may block (lib)vlc. --- src/preparser/preparser.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/src/preparser/preparser.c b/src/preparser/preparser.c index e1463dc701..d9ba21d9f2 100644 --- a/src/preparser/preparser.c +++ b/src/preparser/preparser.c @@ -40,7 +40,17 @@ vlc_preparser_t *vlc_preparser_New(vlc_object_t *obj, if (preparser == NULL) { return NULL; } +#if defined(HAVE_VLC_PROCESS_SPAWN) + const bool external_process = cfg->external_process; +#else if (cfg->external_process) { + assert(!cfg->external_process); + msg_Err(obj, "external preparser requested on unsupported platform"); + return NULL; + } + const bool external_process = false; +#endif + if (external_process) { preparser->sys = vlc_preparser_external_New(preparser, obj, cfg); } else { preparser->sys = vlc_preparser_internal_New(preparser, obj, cfg);