Browse Source

adpcm: reject invalid QuickTime IMA files

DecodeAdpcmImaQT() can only decode up to stereo files.
Fix out of bound write.

Reported by: Patrick Coleman <blinken@gmail.com>

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
pull/46/head
Rafaël Carré 10 years ago
committed by Jean-Baptiste Kempf
parent
commit
458ed62bbe
  1. 6
      modules/codec/adpcm.c

6
modules/codec/adpcm.c

@ -175,6 +175,12 @@ static int OpenDecoder( vlc_object_t *p_this )
switch( p_dec->fmt_in.i_codec )
{
case VLC_FOURCC('i','m','a', '4'): /* IMA ADPCM */
if (p_dec->fmt_in.audio.i_channels > 2) {
free(p_sys);
msg_Err(p_dec, "Invalid number of channels %i",
p_dec->fmt_in.audio.i_channels );
return VLC_EGENERIC;
}
p_sys->codec = ADPCM_IMA_QT;
break;
case VLC_CODEC_ADPCM_IMA_WAV: /* IMA ADPCM */

Loading…
Cancel
Save