mkv: fix leak of ancilliary data

6 months ago · 375e8cdcf4
1 changed files with 7 additions and 1 deletions
--- a/modules/demux/mkv/mkv.cpp
+++ b/modules/demux/mkv/mkv.cpp
@ -745,7 +745,13 @@ static void BlockDecode( demux_t *p_demux, KaxBlock *block, KaxSimpleBlock *simp
                    vlc_ancillary_CreateWithFreeCb(alpha_data, VLC_ANCILLARY_ID_VPX_ALPHA,
                                                   ReleaseVpxAlpha);
                if (likely(alpha != NULL))
-                    vlc_frame_AttachAncillary(p_block, alpha);
+                {
+                    if(vlc_frame_AttachAncillary(p_block, alpha) != VLC_SUCCESS){
+                        vlc_ancillary_Release(alpha);
+                        block_Release(p_block);
+                        return;
+                    }
+                }
                else
                {
                    ReleaseVpxAlpha(alpha_data);