From 335b3feadf2f8e2e0ccad098287d45bf468d4bff Mon Sep 17 00:00:00 2001 From: Steve Lhomme Date: Fri, 10 Jan 2020 14:39:07 +0100 Subject: [PATCH] mmal: codec: remove the out label We just return -1 in all cases. --- modules/hw/mmal/codec.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/modules/hw/mmal/codec.c b/modules/hw/mmal/codec.c index dc3fc08b17..ed3cb96d68 100644 --- a/modules/hw/mmal/codec.c +++ b/modules/hw/mmal/codec.c @@ -305,8 +305,7 @@ static int change_output_format(decoder_t *dec) if (status != MMAL_SUCCESS) { msg_Err(dec, "Failed to disable output port (status=%"PRIx32" %s)", status, mmal_status_to_string(status)); - ret = -1; - goto out; + return -1; } mmal_format_full_copy(sys->output->format, sys->output_format); @@ -314,8 +313,7 @@ static int change_output_format(decoder_t *dec) if (status != MMAL_SUCCESS) { msg_Err(dec, "Failed to commit output format (status=%"PRIx32" %s)", status, mmal_status_to_string(status)); - ret = -1; - goto out; + return -1; } if (sys->opaque) { @@ -333,8 +331,7 @@ static int change_output_format(decoder_t *dec) if (status != MMAL_SUCCESS) { msg_Err(dec, "Failed to enable output port (status=%"PRIx32" %s)", status, mmal_status_to_string(status)); - ret = -1; - goto out; + return -1; } if (!atomic_load(&sys->started)) { @@ -388,7 +385,6 @@ apply_fmt: interlace_type.eMode); } -out: return ret; }