From 07c3f5e51ecd16494c189c7b0af2a59156ea1e4d Mon Sep 17 00:00:00 2001 From: Tristan Matthews Date: Fri, 3 Oct 2025 08:47:50 -0400 Subject: [PATCH] stream_filter: hds: avoid too many XML elements While uint8_t wrap is well defined behavior, logically it's not desirable here. Fixes CID 1666231 --- modules/stream_filter/hds/hds.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/modules/stream_filter/hds/hds.c b/modules/stream_filter/hds/hds.c index 1af2c816bf..c2f5880547 100644 --- a/modules/stream_filter/hds/hds.c +++ b/modules/stream_filter/hds/hds.c @@ -1334,6 +1334,13 @@ static int parse_Manifest( stream_t *s, manifest_t *m ) return VLC_ENOMEM; } } else { + if( current_element_idx == MAX_XML_DEPTH - 1u ) + { + msg_Err( s, "Too many XML elements, quitting" ); + free(media_id); + return VLC_EGENERIC; + } + if ( !( element_stack[++current_element_idx] = strdup( node ) ) ) { free(media_id);