From e12c26fd10711df9f445d339ab93c829d0325202 Mon Sep 17 00:00:00 2001
From: Nicolas Pomepuy <nicolas@videolabs.io>
Date: Mon, 28 Sep 2020 10:19:49 +0200
Subject: [PATCH] Visually increase video player icon size

---
 .../src/main/res/drawable-ldrtl/ic_player_next.xml        | 4 ++--
 .../src/main/res/drawable-ldrtl/ic_player_previous.xml    | 4 ++--
 .../src/main/res/drawable-ldrtl/ic_player_rewind_10.xml   | 4 ++--
 .../res/drawable-ldrtl/ic_player_rewind_10_disabled.xml   | 4 ++--
 .../src/main/res/drawable/ic_player_audiotrack.xml        | 4 ++--
 .../src/main/res/drawable/ic_player_lock_landscape.xml    | 4 ++--
 .../src/main/res/drawable/ic_player_lock_portrait.xml     | 4 ++--
 .../resources/src/main/res/drawable/ic_player_more.xml    | 4 ++--
 .../resources/src/main/res/drawable/ic_player_next.xml    | 4 ++--
 .../src/main/res/drawable/ic_player_previous.xml          | 4 ++--
 .../resources/src/main/res/drawable/ic_player_ratio.xml   | 4 ++--
 .../src/main/res/drawable/ic_player_rewind_10.xml         | 4 ++--
 .../main/res/drawable/ic_player_rewind_10_disabled.xml    | 4 ++--
 .../resources/src/main/res/drawable/ic_player_rotate.xml  | 4 ++--
 application/vlc-android/res/layout/player_hud.xml         | 8 --------
 15 files changed, 28 insertions(+), 36 deletions(-)

diff --git a/application/resources/src/main/res/drawable-ldrtl/ic_player_next.xml b/application/resources/src/main/res/drawable-ldrtl/ic_player_next.xml
index dac892587..ad7b699d3 100644
--- a/application/resources/src/main/res/drawable-ldrtl/ic_player_next.xml
+++ b/application/resources/src/main/res/drawable-ldrtl/ic_player_next.xml
@@ -1,6 +1,6 @@
 <vector xmlns:android="http://schemas.android.com/apk/res/android"
-        android:width="28dp"
-        android:height="28dp"
+        android:width="32dp"
+        android:height="32dp"
         android:tint="#FFFFFF"
         android:viewportWidth="24"
         android:viewportHeight="24">
diff --git a/application/resources/src/main/res/drawable-ldrtl/ic_player_previous.xml b/application/resources/src/main/res/drawable-ldrtl/ic_player_previous.xml
index c735fec94..c229043a2 100644
--- a/application/resources/src/main/res/drawable-ldrtl/ic_player_previous.xml
+++ b/application/resources/src/main/res/drawable-ldrtl/ic_player_previous.xml
@@ -1,6 +1,6 @@
 <vector xmlns:android="http://schemas.android.com/apk/res/android"
-        android:width="28dp"
-        android:height="28dp"
+        android:width="32dp"
+        android:height="32dp"
         android:tint="#FFFFFF"
         android:viewportWidth="24"
         android:viewportHeight="24">
diff --git a/application/resources/src/main/res/drawable-ldrtl/ic_player_rewind_10.xml b/application/resources/src/main/res/drawable-ldrtl/ic_player_rewind_10.xml
index 2f1bddda1..284bd78b1 100644
--- a/application/resources/src/main/res/drawable-ldrtl/ic_player_rewind_10.xml
+++ b/application/resources/src/main/res/drawable-ldrtl/ic_player_rewind_10.xml
@@ -1,6 +1,6 @@
 <vector xmlns:android="http://schemas.android.com/apk/res/android"
-        android:width="28dp"
-        android:height="28dp"
+        android:width="32dp"
+        android:height="32dp"
         android:viewportWidth="36"
         android:viewportHeight="36">
   <path
diff --git a/application/resources/src/main/res/drawable-ldrtl/ic_player_rewind_10_disabled.xml b/application/resources/src/main/res/drawable-ldrtl/ic_player_rewind_10_disabled.xml
index 60a6fd82c..1c6cdd697 100644
--- a/application/resources/src/main/res/drawable-ldrtl/ic_player_rewind_10_disabled.xml
+++ b/application/resources/src/main/res/drawable-ldrtl/ic_player_rewind_10_disabled.xml
@@ -1,6 +1,6 @@
 <vector xmlns:android="http://schemas.android.com/apk/res/android"
-        android:width="28dp"
-        android:height="28dp"
+        android:width="32dp"
+        android:height="32dp"
         android:viewportWidth="36"
         android:viewportHeight="36">
   <path
diff --git a/application/resources/src/main/res/drawable/ic_player_audiotrack.xml b/application/resources/src/main/res/drawable/ic_player_audiotrack.xml
index aca01432b..ae8b846fc 100644
--- a/application/resources/src/main/res/drawable/ic_player_audiotrack.xml
+++ b/application/resources/src/main/res/drawable/ic_player_audiotrack.xml
@@ -1,6 +1,6 @@
 <vector xmlns:android="http://schemas.android.com/apk/res/android"
-    android:width="28dp"
-    android:height="28dp"
+    android:width="32dp"
+    android:height="32dp"
     android:viewportWidth="36"
     android:viewportHeight="36">
   <path
diff --git a/application/resources/src/main/res/drawable/ic_player_lock_landscape.xml b/application/resources/src/main/res/drawable/ic_player_lock_landscape.xml
index ff87c2c8f..ad9c810e4 100644
--- a/application/resources/src/main/res/drawable/ic_player_lock_landscape.xml
+++ b/application/resources/src/main/res/drawable/ic_player_lock_landscape.xml
@@ -1,6 +1,6 @@
 <vector xmlns:android="http://schemas.android.com/apk/res/android"
-    android:width="28dp"
-    android:height="28dp"
+    android:width="32dp"
+    android:height="32dp"
     android:viewportWidth="36"
     android:viewportHeight="36">
   <path
diff --git a/application/resources/src/main/res/drawable/ic_player_lock_portrait.xml b/application/resources/src/main/res/drawable/ic_player_lock_portrait.xml
index e64124d7a..1569ff05f 100644
--- a/application/resources/src/main/res/drawable/ic_player_lock_portrait.xml
+++ b/application/resources/src/main/res/drawable/ic_player_lock_portrait.xml
@@ -1,6 +1,6 @@
 <vector xmlns:android="http://schemas.android.com/apk/res/android"
-    android:width="28dp"
-    android:height="28dp"
+    android:width="32dp"
+    android:height="32dp"
     android:viewportWidth="36"
     android:viewportHeight="36">
   <path
diff --git a/application/resources/src/main/res/drawable/ic_player_more.xml b/application/resources/src/main/res/drawable/ic_player_more.xml
index af7718740..fd3328823 100644
--- a/application/resources/src/main/res/drawable/ic_player_more.xml
+++ b/application/resources/src/main/res/drawable/ic_player_more.xml
@@ -1,6 +1,6 @@
 <vector xmlns:android="http://schemas.android.com/apk/res/android"
-    android:width="28dp"
-    android:height="28dp"
+    android:width="32dp"
+    android:height="32dp"
     android:viewportWidth="36"
     android:viewportHeight="36">
   <path
diff --git a/application/resources/src/main/res/drawable/ic_player_next.xml b/application/resources/src/main/res/drawable/ic_player_next.xml
index cf5f111ff..5f5f7758f 100644
--- a/application/resources/src/main/res/drawable/ic_player_next.xml
+++ b/application/resources/src/main/res/drawable/ic_player_next.xml
@@ -1,6 +1,6 @@
 <vector xmlns:android="http://schemas.android.com/apk/res/android"
-        android:width="28dp"
-        android:height="28dp"
+        android:width="32dp"
+        android:height="32dp"
         android:tint="#FFFFFF"
         android:viewportWidth="24"
         android:viewportHeight="24">
diff --git a/application/resources/src/main/res/drawable/ic_player_previous.xml b/application/resources/src/main/res/drawable/ic_player_previous.xml
index 18f661f2e..dcd37a561 100644
--- a/application/resources/src/main/res/drawable/ic_player_previous.xml
+++ b/application/resources/src/main/res/drawable/ic_player_previous.xml
@@ -1,6 +1,6 @@
 <vector xmlns:android="http://schemas.android.com/apk/res/android"
-        android:width="28dp"
-        android:height="28dp"
+        android:width="32dp"
+        android:height="32dp"
         android:tint="#FFFFFF"
         android:viewportWidth="24"
         android:viewportHeight="24">
diff --git a/application/resources/src/main/res/drawable/ic_player_ratio.xml b/application/resources/src/main/res/drawable/ic_player_ratio.xml
index efd8be54d..3689615d0 100644
--- a/application/resources/src/main/res/drawable/ic_player_ratio.xml
+++ b/application/resources/src/main/res/drawable/ic_player_ratio.xml
@@ -1,6 +1,6 @@
 <vector xmlns:android="http://schemas.android.com/apk/res/android"
-    android:width="28dp"
-    android:height="28dp"
+    android:width="32dp"
+    android:height="32dp"
     android:viewportWidth="36"
     android:viewportHeight="36">
   <path
diff --git a/application/resources/src/main/res/drawable/ic_player_rewind_10.xml b/application/resources/src/main/res/drawable/ic_player_rewind_10.xml
index 53ee068d1..daa86f6b8 100644
--- a/application/resources/src/main/res/drawable/ic_player_rewind_10.xml
+++ b/application/resources/src/main/res/drawable/ic_player_rewind_10.xml
@@ -1,6 +1,6 @@
 <vector xmlns:android="http://schemas.android.com/apk/res/android"
-    android:width="28dp"
-    android:height="28dp"
+    android:width="32dp"
+    android:height="32dp"
     android:viewportWidth="36"
     android:viewportHeight="36">
   <path
diff --git a/application/resources/src/main/res/drawable/ic_player_rewind_10_disabled.xml b/application/resources/src/main/res/drawable/ic_player_rewind_10_disabled.xml
index 75b7f26cc..ea8db4481 100644
--- a/application/resources/src/main/res/drawable/ic_player_rewind_10_disabled.xml
+++ b/application/resources/src/main/res/drawable/ic_player_rewind_10_disabled.xml
@@ -1,6 +1,6 @@
 <vector xmlns:android="http://schemas.android.com/apk/res/android"
-        android:width="28dp"
-        android:height="28dp"
+        android:width="32dp"
+        android:height="32dp"
         android:viewportWidth="36"
         android:viewportHeight="36">
   <path
diff --git a/application/resources/src/main/res/drawable/ic_player_rotate.xml b/application/resources/src/main/res/drawable/ic_player_rotate.xml
index 9f28580db..21176f075 100644
--- a/application/resources/src/main/res/drawable/ic_player_rotate.xml
+++ b/application/resources/src/main/res/drawable/ic_player_rotate.xml
@@ -1,6 +1,6 @@
 <vector xmlns:android="http://schemas.android.com/apk/res/android"
-    android:width="28dp"
-    android:height="28dp"
+    android:width="32dp"
+    android:height="32dp"
     android:viewportWidth="36"
     android:viewportHeight="36">
   <path
diff --git a/application/vlc-android/res/layout/player_hud.xml b/application/vlc-android/res/layout/player_hud.xml
index f8318b34b..b625d0f83 100644
--- a/application/vlc-android/res/layout/player_hud.xml
+++ b/application/vlc-android/res/layout/player_hud.xml
@@ -306,7 +306,6 @@
                     android:contentDescription="@string/tracks"
                     android:focusable="true"
                     android:onClick="@{player::onAudioSubClick}"
-                    android:padding="4dp"
                     android:scaleType="center"
                     tools:visibility="visible"
                     vlc:layout_constraintBottom_toBottomOf="@+id/player_overlay_play"
@@ -325,7 +324,6 @@
                     android:layout_marginEnd="8dp"
                     android:background="?attr/selectableItemBackgroundBorderless"
                     android:focusable="true"
-                    android:padding="4dp"
                     android:visibility="invisible"
                     tools:visibility="visible"
                     vlc:layout_constraintBottom_toBottomOf="@+id/player_overlay_play"
@@ -353,7 +351,6 @@
                     android:contentDescription="@string/previous"
                     android:focusable="true"
                     android:longClickable="true"
-                    android:padding="4dp"
                     android:onClick="@{(v) -> player.previous()}"
                     android:scaleType="center"
                     android:visibility="gone"
@@ -373,7 +370,6 @@
                     android:clickable="true"
                     android:contentDescription="@string/playback_rewind"
                     android:focusable="true"
-                    android:padding="4dp"
                     android:longClickable="true"
                     android:scaleType="center"
                     android:visibility="gone"
@@ -411,7 +407,6 @@
                     android:clickable="true"
                     android:contentDescription="@string/playback_forward"
                     android:focusable="true"
-                    android:padding="4dp"
                     android:longClickable="true"
                     android:scaleType="center"
                     android:visibility="gone"
@@ -435,7 +430,6 @@
                     android:onClick="@{(v) -> player.next()}"
                     android:scaleType="center"
                     android:visibility="gone"
-                    android:padding="4dp"
                     tools:visibility="visible"
                     vlc:layout_constraintBottom_toBottomOf="@+id/player_overlay_play"
                     vlc:layout_constraintEnd_toStartOf="@+id/player_space_right"
@@ -464,7 +458,6 @@
                     android:focusable="true"
                     android:onClick="@{(v) -> player.resizeVideo()}"
                     android:scaleType="center"
-                    android:padding="4dp"
                     tools:visibility="visible"
                     vlc:layout_constraintBottom_toBottomOf="@+id/player_overlay_play"
                     vlc:layout_constraintEnd_toStartOf="@+id/player_overlay_adv_function"
@@ -482,7 +475,6 @@
                     android:contentDescription="@string/advanced"
                     android:focusable="true"
                     android:onClick="@{(v) -> player.showAdvancedOptions()}"
-                    android:padding="4dp"
                     android:scaleType="center"
                     tools:visibility="visible"
                     vlc:layout_constraintBottom_toBottomOf="@+id/player_overlay_play"