Re-add setting for fast seek

fixes #2415

application/resources/src/main/res/values/strings.xml

@@ -918,5 +918,7 @@
     <string name="view_online">View online</string>
     <string name="player_under_notch">Display video under notch</string>
     <string name="notch">Notch</string>
+    <string name="always_fast_seek">Always use fast seek</string>
+    <string name="always_fast_seek_summary">Seek is faster but may be less precise</string>
 
 </resources>

application/vlc-android/res/xml/preferences_video.xml

@@ -22,6 +22,12 @@
             android:key="playback_speed_video"
             android:summary="@string/playback_speed_summary"
             android:title="@string/playback_speed_title"/>
+    <CheckBoxPreference
+            app:singleLineTitle="false"
+            android:defaultValue="false"
+            android:key="always_fast_seek"
+            android:summary="@string/always_fast_seek_summary"
+            android:title="@string/always_fast_seek"/>
     <CheckBoxPreference
             app:singleLineTitle="false"
             android:defaultValue="true"

application/vlc-android/src/org/videolan/vlc/PlaybackService.kt

@@ -772,7 +772,8 @@ class PlaybackService : MediaBrowserServiceCompat(), LifecycleOwner, CoroutineSc
     }
 
     fun setTime(time:Long, fast:Boolean = false) {
-        playlistManager.player.setTime(time, fast)
+        val shouldFast = fast || (!playlistManager.isBenchmark && settings.getBoolean("always_fast_seek", false))
+        playlistManager.player.setTime(time, shouldFast)
         publishState(time)
     }
 

application/vlc-android/src/org/videolan/vlc/media/PlaylistManager.kt

@@ -993,7 +993,7 @@ class PlaylistManager(val service: PlaybackService) : MediaWrapperList.EventList
                 }
                 MediaPlayer.Event.TimeChanged -> {
                     abRepeat.value?.let {
-                        if (it.stop != -1L && player.getCurrentTime() > it.stop) player.setTime(it.start)
+                        if (it.stop != -1L && player.getCurrentTime() > it.stop) service.setTime(it.start)
                     }
                     if (player.getCurrentTime() % 10 == 0L) savePosition()
                 }