Browse Source

UB in negate in mulh/mulhsu

Ensuring No negation on -2^63(int64_t) is performed during mulh/mulhsu

Signed-off-by: Nicolas Brunie <82109999+nibrunieAtSi5@users.noreply.github.com>

Update riscv/arith.h

Signed-off-by: Nicolas Brunie <82109999+nibrunieAtSi5@users.noreply.github.com>
pull/1546/head
Nicolas Brunie 3 years ago
committed by Nicolas Brunie
parent
commit
fd077496cd
  1. 6
      riscv/arith.h

6
riscv/arith.h

@ -32,15 +32,15 @@ inline uint64_t mulhu(uint64_t a, uint64_t b)
inline int64_t mulh(int64_t a, int64_t b)
{
int negate = (a < 0) != (b < 0);
uint64_t res = mulhu(a < 0 ? -a : a, b < 0 ? -b : b);
uint64_t res = mulhu(a < 0 ? -(uint64_t)a : a, b < 0 ? -(uint64_t)b : b);
return negate ? ~res + ((uint64_t)a * (uint64_t)b == 0) : res;
}
inline int64_t mulhsu(int64_t a, uint64_t b)
{
int negate = a < 0;
uint64_t res = mulhu(a < 0 ? -a : a, b);
return negate ? ~res + (a * b == 0) : res;
uint64_t res = mulhu(a < 0 ? -(uint64_t)a : a, b);
return negate ? ~res + ((uint64_t)a * b == 0) : res;
}
//ref: https://locklessinc.com/articles/sat_arithmetic/

Loading…
Cancel
Save