Browse Source

restore clang support by fixing printf identifiers

pull/67/head
Scott Beamer 10 years ago
parent
commit
5762bedab3
  1. 12
      riscv/debug_module.cc
  2. 20
      riscv/gdbserver.cc

12
riscv/debug_module.cc

@ -19,8 +19,8 @@ bool debug_module_t::load(reg_t addr, size_t len, uint8_t* bytes)
return true; return true;
} }
fprintf(stderr, "ERROR: invalid load from debug module: %ld bytes at 0x%lx\n", fprintf(stderr, "ERROR: invalid load from debug module: %ld bytes at 0x%016"
len, addr); PRIx64 "\n", len, addr);
return false; return false;
} }
@ -29,8 +29,8 @@ bool debug_module_t::store(reg_t addr, size_t len, const uint8_t* bytes)
addr = DEBUG_START + addr; addr = DEBUG_START + addr;
if (addr & (len-1)) { if (addr & (len-1)) {
fprintf(stderr, "ERROR: unaligned store to debug module: %ld bytes at 0x%lx\n", fprintf(stderr, "ERROR: unaligned store to debug module: %ld bytes at 0x%016"
len, addr); PRIx64 "\n", len, addr);
return false; return false;
} }
@ -47,8 +47,8 @@ bool debug_module_t::store(reg_t addr, size_t len, const uint8_t* bytes)
return true; return true;
} }
fprintf(stderr, "ERROR: invalid store to debug module: %ld bytes at 0x%lx\n", fprintf(stderr, "ERROR: invalid store to debug module: %ld bytes at 0x%016"
len, addr); PRIx64 "\n", len, addr);
return false; return false;
} }

20
riscv/gdbserver.cc

@ -9,6 +9,7 @@
#include <algorithm> #include <algorithm>
#include <cassert> #include <cassert>
#include <cinttypes>
#include <cstdio> #include <cstdio>
#include <vector> #include <vector>
@ -848,8 +849,9 @@ class memory_write_op_t : public operation_t
(data[6] << 16) | (data[7] << 24)); (data[6] << 16) | (data[7] << 24));
break; break;
default: default:
fprintf(stderr, "gdbserver error: write %d bytes to 0x%lx -> 0x%lx; " fprintf(stderr, "gdbserver error: write %d bytes to 0x%016" PRIx64
"access_size=%d\n", length, vaddr, paddr, access_size); " -> 0x%016" PRIx64 "; access_size=%d\n",
length, vaddr, paddr, access_size);
gs.send_packet("E12"); gs.send_packet("E12");
return true; return true;
} }
@ -861,8 +863,8 @@ class memory_write_op_t : public operation_t
} }
if (gs.dr_read32(DEBUG_RAM_SIZE / 4 - 1)) { if (gs.dr_read32(DEBUG_RAM_SIZE / 4 - 1)) {
fprintf(stderr, "Exception happened while writing to 0x%lx -> 0x%lx\n", fprintf(stderr, "Exception happened while writing to 0x%016" PRIx64
vaddr, paddr); " -> 0x%016" PRIx64 "\n", vaddr, paddr);
} }
offset += access_size; offset += access_size;
@ -1019,7 +1021,7 @@ class collect_translation_info_op_t : public operation_t
} }
} }
fprintf(stderr, fprintf(stderr,
"ERROR: gdbserver couldn't find appropriate PTEs to translate 0x%lx\n", "ERROR: gdbserver couldn't find appropriate PTEs to translate 0x%016" PRIx64 "\n",
vaddr); vaddr);
return true; return true;
} }
@ -1306,8 +1308,8 @@ reg_t gdbserver_t::translate(reg_t vaddr)
reg_t pte_addr = base + idx * ptesize; reg_t pte_addr = base + idx * ptesize;
auto it = pte_cache.find(pte_addr); auto it = pte_cache.find(pte_addr);
if (it == pte_cache.end()) { if (it == pte_cache.end()) {
fprintf(stderr, "ERROR: gdbserver tried to translate 0x%lx without first " fprintf(stderr, "ERROR: gdbserver tried to translate 0x%016" PRIx64
"collecting the relevant PTEs.\n", vaddr); " without first collecting the relevant PTEs.\n", vaddr);
die("gdbserver_t::translate()"); die("gdbserver_t::translate()");
} }
@ -1326,8 +1328,8 @@ reg_t gdbserver_t::translate(reg_t vaddr)
} }
} }
fprintf(stderr, "ERROR: gdbserver tried to translate 0x%lx but the relevant " fprintf(stderr, "ERROR: gdbserver tried to translate 0x%016" PRIx64
"PTEs are invalid.\n", vaddr); " but the relevant PTEs are invalid.\n", vaddr);
// TODO: Is it better to throw an exception here? // TODO: Is it better to throw an exception here?
return -1; return -1;
} }

Loading…
Cancel
Save