riscv/qemu: QEMU main repository: Please see https://www.qemu.org/docs/master/devel/submitting-a-patch.html for how to submit changes to QEMU. Pull Requests are ignored. Please only use release tarballs from the QEMU website. http://www.qemu.org - qemu

QEMU main repository: Please see https://www.qemu.org/docs/master/devel/submitting-a-patch.html for how to submit changes to QEMU. Pull Requests are ignored. Please only use release tarballs from the QEMU website. http://www.qemu.org

emulation kvm qemu virtualization

History

Peter Maydell 4c107870e8 migration/multifd: Free MultiFDRecvParams::data In multifd_recv_setup() we allocate (among other things) * a MultiFDRecvData struct to multifd_recv_state::data * a MultiFDRecvData struct to each multfd_recv_state->params[i].data (Then during execution we might swap these pointers around.) But in multifd_recv_cleanup() we free multifd_recv_state->data in multifd_recv_cleanup_state() but we don't ever free the multifd_recv_state->params[i].data. This results in a memory leak reported by LeakSanitizer: (cd build/asan && \ ASAN_OPTIONS="fast_unwind_on_malloc=0:strip_path_prefix=/mnt/nvmedisk/linaro/qemu-from-laptop/qemu/build/asan/../../" \ QTEST_QEMU_BINARY=./qemu-system-x86_64 \ ./tests/qtest/migration-test --tap -k -p /x86_64/migration/multifd/file/mapped-ram ) [...] Direct leak of 72 byte(s) in 3 object(s) allocated from: #0 0x561cc0afcfd8 in __interceptor_calloc (/mnt/nvmedisk/linaro/qemu-from-laptop/qemu/build/asan/qemu-system-x86_64+0x218efd8) (BuildId: be72e086d4e47b172b0a72779972213fd9916466) #1 0x7f89d37acc50 in g_malloc0 debian/build/deb/../../../glib/gmem.c:161:13 #2 0x561cc1e9c83c in multifd_recv_setup migration/multifd.c:1606:19 #3 0x561cc1e68618 in migration_ioc_process_incoming migration/migration.c:972:9 #4 0x561cc1e3ac59 in migration_channel_process_incoming migration/channel.c:45:9 #5 0x561cc1e4fa0b in file_accept_incoming_migration migration/file.c:132:5 #6 0x561cc30f2c0c in qio_channel_fd_source_dispatch io/channel-watch.c:84:12 #7 0x7f89d37a3c43 in g_main_dispatch debian/build/deb/../../../glib/gmain.c:3419:28 #8 0x7f89d37a3c43 in g_main_context_dispatch debian/build/deb/../../../glib/gmain.c:4137:7 #9 0x561cc3b21659 in glib_pollfds_poll util/main-loop.c:287:9 #10 0x561cc3b1ff93 in os_host_main_loop_wait util/main-loop.c:310:5 #11 0x561cc3b1fb5c in main_loop_wait util/main-loop.c:589:11 #12 0x561cc1da2917 in qemu_main_loop system/runstate.c:801:9 #13 0x561cc3796c1c in qemu_default_main system/main.c:37:14 #14 0x561cc3796c67 in main system/main.c:48:12 #15 0x7f89d163bd8f in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16 #16 0x7f89d163be3f in __libc_start_main csu/../csu/libc-start.c:392:3 #17 0x561cc0a79fa4 in _start (/mnt/nvmedisk/linaro/qemu-from-laptop/qemu/build/asan/qemu-system-x86_64+0x210bfa4) (BuildId: be72e086d4e47b172b0a72779972213fd9916466) Direct leak of 24 byte(s) in 1 object(s) allocated from: #0 0x561cc0afcfd8 in __interceptor_calloc (/mnt/nvmedisk/linaro/qemu-from-laptop/qemu/build/asan/qemu-system-x86_64+0x218efd8) (BuildId: be72e086d4e47b172b0a72779972213fd9916466) #1 0x7f89d37acc50 in g_malloc0 debian/build/deb/../../../glib/gmem.c:161:13 #2 0x561cc1e9bed9 in multifd_recv_setup migration/multifd.c:1588:32 #3 0x561cc1e68618 in migration_ioc_process_incoming migration/migration.c:972:9 #4 0x561cc1e3ac59 in migration_channel_process_incoming migration/channel.c:45:9 #5 0x561cc1e4fa0b in file_accept_incoming_migration migration/file.c:132:5 #6 0x561cc30f2c0c in qio_channel_fd_source_dispatch io/channel-watch.c:84:12 #7 0x7f89d37a3c43 in g_main_dispatch debian/build/deb/../../../glib/gmain.c:3419:28 #8 0x7f89d37a3c43 in g_main_context_dispatch debian/build/deb/../../../glib/gmain.c:4137:7 #9 0x561cc3b21659 in glib_pollfds_poll util/main-loop.c:287:9 #10 0x561cc3b1ff93 in os_host_main_loop_wait util/main-loop.c:310:5 #11 0x561cc3b1fb5c in main_loop_wait util/main-loop.c:589:11 #12 0x561cc1da2917 in qemu_main_loop system/runstate.c:801:9 #13 0x561cc3796c1c in qemu_default_main system/main.c:37:14 #14 0x561cc3796c67 in main system/main.c:48:12 #15 0x7f89d163bd8f in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16 #16 0x7f89d163be3f in __libc_start_main csu/../csu/libc-start.c:392:3 #17 0x561cc0a79fa4 in _start (/mnt/nvmedisk/linaro/qemu-from-laptop/qemu/build/asan/qemu-system-x86_64+0x210bfa4) (BuildId: be72e086d4e47b172b0a72779972213fd9916466) SUMMARY: AddressSanitizer: 96 byte(s) leaked in 4 allocation(s). Free the params[i].data too. Cc: qemu-stable@nongnu.org Fixes: `d117ed0699` ("migration/multifd: Allow receiving pages without packets") Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Fabiano Rosas <farosas@suse.de> Signed-off-by: Fabiano Rosas <farosas@suse.de>		2 years ago
..
block-dirty-bitmap.c	migration: Add Error** argument to add_bitmaps_to_list()	2 years ago
channel-block.c	io: follow coroutine AioContext in qio_channel_yield()	3 years ago
channel-block.h	migration: introduce a QIOChannel impl for BlockDriverState VMState	4 years ago
channel.c	migration: Fix migration_channel_read_peek() error path	2 years ago
channel.h	migration: check magic value for deciding the mapping of channels	3 years ago
colo-failover.c	migration/colo: Improve an x-colo-lost-heartbeat error message	3 years ago
colo-stubs.c	migration/colo: make colo_incoming_co() return void	2 years ago
colo.c	migration: Rename thread debug names	2 years ago
dirtyrate.c	migration: remove unnecessary zlib dependency	2 years ago
dirtyrate.h	migration/calc-dirty-rate: millisecond-granularity period	3 years ago
exec.c	migration: simplify exec migration functions	2 years ago
exec.h	migration: convert exec backend to accept MigrateAddress.	2 years ago
fd.c	migration: Deprecate fd: for file migration	2 years ago
fd.h	migration: Revert mapped-ram multifd support to fd: URI	2 years ago
file.c	migration: Fix cleanup of iochannel in file migration	2 years ago
file.h	migration/multifd: Add direct-io support	2 years ago
global_state.c	migration 1st pull for 9.0	2 years ago
meson.build	migration/multifd: add uadk compression framework	2 years ago
migration-hmp-cmds.c	migration: Add direct-io parameter	2 years ago
migration-stats.c	migration: migration_rate_limit_reset() don't need the QEMUFile	2 years ago
migration-stats.h	migration: Remove transferred atomic counter	2 years ago
migration.c	migration/postcopy: Add postcopy-recover-setup phase	2 years ago
migration.h	migration: Use MigrationStatus instead of int	2 years ago
multifd-qpl.c	migration/multifd: implement qpl compression and decompression	2 years ago
multifd-uadk.c	migration/multifd: Switch to no compression when no hardware support	2 years ago
multifd-zero-page.c	migration/multifd: solve zero page causing multiple page faults	2 years ago
multifd-zlib.c	migration/multifd: put IOV initialization into compression method	2 years ago
multifd-zstd.c	migration/multifd: put IOV initialization into compression method	2 years ago
multifd.c	migration/multifd: Free MultiFDRecvParams::data	2 years ago
multifd.h	migration/multifd: add uadk compression framework	2 years ago
options.c	migration: Add direct-io parameter	2 years ago
options.h	migration: Add direct-io parameter	2 years ago
page_cache.c	migration: Fix cache_init()'s "Failed to allocate" error messages	5 years ago
page_cache.h	migration: Clean up signed vs. unsigned XBZRLE cache-size	5 years ago
postcopy-ram.c	migration/postcopy: Add postcopy-recover-setup phase	2 years ago
postcopy-ram.h	migration/postcopy: Add postcopy-recover-setup phase	2 years ago
qemu-file.c	migration: remove unnecessary zlib dependency	2 years ago
qemu-file.h	migration: Remove non-multifd compression	2 years ago
ram.c	migration/multifd: Avoid the final FLUSH in complete()	2 years ago
ram.h	migration/multifd: solve zero page causing multiple page faults	2 years ago
rdma.c	migration/rdma: Fix a memory issue for migration	2 years ago
rdma.h	migration: convert rdma backend to accept MigrateAddress	2 years ago
savevm.c	savevm: Fix load_snapshot error path crash	2 years ago
savevm.h	migration: Add Error** argument to qemu_savevm_state_setup()	2 years ago
socket.c	migration/multifd: Drop unnecessary helper to destroy IOC	2 years ago
socket.h	migration/multifd: Drop unnecessary helper to destroy IOC	2 years ago
target.c	migration: Add migration prefix to functions in target.c	3 years ago
threadinfo.c	migration/multifd: Protect accesses to migration_threads	3 years ago
threadinfo.h	migration/multifd: Protect accesses to migration_threads	3 years ago
tls.c	migration: Drop unused parameter for migration_tls_client_create()	3 years ago
tls.h	migration: Drop unused parameter for migration_tls_client_create()	3 years ago
trace-events	migration: add "exists" info to load-state-field trace	2 years ago
trace.h	trace: switch position of headers to what Meson requires	6 years ago
vmstate-types.c	Move CPU softfloat unions to cpu-float.h	4 years ago
vmstate.c	migration: fix a typo	2 years ago
xbzrle.c	migration/xbzrle: Use i386 host/cpuinfo.h	3 years ago
xbzrle.h	migration/xbzrle: Use i386 host/cpuinfo.h	3 years ago
yank_functions.c	migration/yank: Use channel features	2 years ago
yank_functions.h	migration: Move the yank unregister of channel_close out	5 years ago