riscv/qemu: QEMU main repository: Please see https://www.qemu.org/docs/master/devel/submitting-a-patch.html for how to submit changes to QEMU. Pull Requests are ignored. Please only use release tarballs from the QEMU website. http://www.qemu.org - qemu

QEMU main repository: Please see https://www.qemu.org/docs/master/devel/submitting-a-patch.html for how to submit changes to QEMU. Pull Requests are ignored. Please only use release tarballs from the QEMU website. http://www.qemu.org

Tree: e6dbff3fb8

History

Eric Blake ef2e35fcc8 nbd/client: Drop pointless buf variable There's no need to read into a temporary buffer (oversized since commit `7d3123e1`) followed by a byteswap into a uint64_t to check for a magic number via memcmp(), when the code immediately below demonstrates reading into the uint64_t then byteswapping in place and checking for a magic number via integer math. What's more, having a different error message when the server's first reply byte is 0 is unusual - it's no different from any other wrong magic number, and we already detected short reads. That whole strlen() issue has been present and useless since commit `1d45f8b5` in 2010; perhaps it was leftover debugging (since the correct magic number happens to be ASCII)? Make the error messages more consistent and detailed while touching things. Signed-off-by: Eric Blake <eblake@redhat.com> Reviewed-by: Richard W.M. Jones <rjones@redhat.com> Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> Message-Id: <20181215135324.152629-9-eblake@redhat.com>		7 years ago
..
Makefile.objs	nbd: Split nbd.c	10 years ago
client.c	nbd/client: Drop pointless buf variable	7 years ago
common.c	nbd/server: introduce NBD_CMD_CACHE	8 years ago
nbd-internal.h	nbd/client: Drop pointless buf variable	7 years ago
server.c	nbd/server: Advertise all contexts in response to bare LIST	7 years ago
trace-events	nbd/client: Trace all server option error messages	7 years ago