riscv/qemu: QEMU main repository: Please see https://www.qemu.org/docs/master/devel/submitting-a-patch.html for how to submit changes to QEMU. Pull Requests are ignored. Please only use release tarballs from the QEMU website. http://www.qemu.org - qemu

QEMU main repository: Please see https://www.qemu.org/docs/master/devel/submitting-a-patch.html for how to submit changes to QEMU. Pull Requests are ignored. Please only use release tarballs from the QEMU website. http://www.qemu.org

emulation kvm qemu virtualization

History

Eric Blake de252f7993 qio: Add QIONetListener API for using AioContext The user calling himself "John Doe" reported a deadlock when attempting to use qemu-storage-daemon to serve both a base file over NBD, and a qcow2 file with that NBD export as its backing file, from the same process, even though it worked just fine when there were two q-s-d processes. The bulk of the NBD server code properly uses coroutines to make progress in an event-driven manner, but the code for spawning a new coroutine at the point when listen(2) detects a new client was hard-coded to use the global GMainContext; in other words, the callback that triggers nbd_client_new to let the server start the negotiation sequence with the client requires the main loop to be making progress. However, the code for bdrv_open of a qcow2 image with an NBD backing file uses an AIO_WAIT_WHILE nested event loop to ensure that the entire qcow2 backing chain is either fully loaded or rejected, without any side effects from the main loop causing unwanted changes to the disk being loaded (in short, an AioContext represents the set of actions that are known to be safe while handling block layer I/O, while excluding any other pending actions in the global main loop with potentially larger risk of unwanted side effects). This creates a classic case of deadlock: the server can't progress to the point of accept(2)ing the client to write to the NBD socket because the main loop is being starved until the AIO_WAIT_WHILE completes the bdrv_open, but the AIO_WAIT_WHILE can't progress because it is blocked on the client coroutine stuck in a read() of the expected magic number from the server side of the socket. This patch adds a new API to allow clients to opt in to listening via an AioContext rather than a GMainContext. This will allow NBD to fix the deadlock by performing all actions during bdrv_open in the main loop AioContext. Technical debt warning: I would have loved to utilize a notify function with AioContext to guarantee that we don't finalize listener due to an object_unref if there is any callback still running (the way GSource does), but wiring up notify functions into AioContext is a bigger task that will be deferred to a later QEMU release. But for solving the NBD deadlock, it is sufficient to note that the QMP commands for enabling and disabling the NBD server are really the only points where we want to change the listener's callback. Furthermore, those commands are serviced in the main loop, which is the same AioContext that is also listening for connections. Since a thread cannot interrupt itself, we are ensured that at the point where we are changing the watch, there are no callbacks active. This is NOT as powerful as the GSource cross-thread safety, but sufficient for the needs of today. An upcoming patch will then add a unit test (kept separate to make it easier to rearrange the series to demonstrate the deadlock without this patch). Fixes: https://gitlab.com/qemu-project/qemu/-/issues/3169 Signed-off-by: Eric Blake <eblake@redhat.com> Message-ID: <20251113011625.878876-26-eblake@redhat.com> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>		5 months ago
..
channel-buffer.c	qom: Have class_init() take a const data argument	11 months ago
channel-command.c	treewide: use qemu_set_blocking instead of g_unix_set_fd_nonblocking	6 months ago
channel-file.c	treewide: use qemu_set_blocking instead of g_unix_set_fd_nonblocking	6 months ago
channel-null.c	qom: Have class_init() take a const data argument	11 months ago
channel-socket.c	io: flush zerocopy socket error queue on sendmsg failure due to ENOBUF	5 months ago
channel-tls.c	io/channel: Have read/write functions take void * buffer argument	5 months ago
channel-util.c	io: follow coroutine AioContext in qio_channel_yield()	3 years ago
channel-watch.c	error: Kill @error_warn	6 months ago
channel-websock.c	io: fix use after free in websocket handshake code	5 months ago
channel.c	mem + migration pull for 10.2	5 months ago
dns-resolver.c	io: Fix partial struct copy in qio_dns_resolver_lookup_sync_inet()	10 months ago
meson.build	Revert "meson: Propagate gnutls dependency"	2 years ago
net-listener.c	qio: Add QIONetListener API for using AioContext	5 months ago
task.c	io: Fix Lesser GPL version number	5 years ago
trace-events	qio: Prepare NetListener to use AioContext	5 months ago
trace.h	trace: switch position of headers to what Meson requires	6 years ago