You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
Markus Armbruster
4b5766488f
error: Fix use of error_prepend() with &error_fatal, &error_abort From include/qapi/error.h:
* Pass an existing error to the caller with the message modified:
* error_propagate(errp, err);
* error_prepend(errp, "Could not frobnicate '%s': ", name);
Fei Li pointed out that doing error_propagate() first doesn't work
well when @errp is &error_fatal or &error_abort: the error_prepend()
is never reached.
Since I doubt fixing the documentation will stop people from getting
it wrong, introduce error_propagate_prepend(), in the hope that it
lures people away from using its constituents in the wrong order.
Update the instructions in error.h accordingly.
Convert existing error_prepend() next to error_propagate to
error_propagate_prepend(). If any of these get reached with
&error_fatal or &error_abort, the error messages improve. I didn't
check whether that's the case anywhere.
Cc: Fei Li <fli@suse.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-Id: <20181017082702.5581-2-armbru@redhat.com>
8 years ago
..
Makefile.objs
usb: Add basic code to emulate Chipidea USB IP
9 years ago
bus.c
error: Fix use of error_prepend() with &error_fatal, &error_abort
8 years ago
ccid-card-emulated.c
ccid-card: include libcacard.h only
8 years ago
ccid-card-passthru.c
hw/usb: Use the IEC binary prefix definitions
8 years ago
ccid.h
usb-ccid: convert CCIDCardClass::exitfn() -> unrealize()
9 years ago
chipidea.c
usb: Add basic code to emulate Chipidea USB IP
9 years ago
combined-packet.c
hw/usb: Use the IEC binary prefix definitions
8 years ago
core.c
usb: don't wakeup during coldplug
9 years ago
desc-msos.c
usb: use local path for local headers
8 years ago
desc.c
usb: use local path for local headers
8 years ago
desc.h
all: Clean up includes
11 years ago
dev-audio.c
usb: use local path for local headers
8 years ago
dev-bluetooth.c
usb: use local path for local headers
8 years ago
dev-hid.c
usb: use local path for local headers
8 years ago
dev-hub.c
usb-hub: clear suspend on detach
8 years ago
dev-mtp.c
usb-mtp: reset ObjectInfo dataset size on cleanup
8 years ago
dev-network.c
usb: use local path for local headers
8 years ago
dev-serial.c
usb: use local path for local headers
8 years ago
dev-smartcard-reader.c
hw/usb: Use the IEC binary prefix definitions
8 years ago
dev-storage.c
block: Remove deprecated -drive option serial
8 years ago
dev-uas.c
Revert "usb: release the created buses"
8 years ago
dev-wacom.c
usb: use local path for local headers
8 years ago
hcd-ehci-pci.c
pci: Add INTERFACE_CONVENTIONAL_PCI_DEVICE to Conventional PCI devices
9 years ago
hcd-ehci-sysbus.c
ehci: Add ppc4xx-ehci for the USB 2.0 controller in embedded PPC SoCs
9 years ago
hcd-ehci.c
ehci: Don't fetch a NULL current qtd but advance the queue instead.
8 years ago
hcd-ehci.h
ehci: Add ppc4xx-ehci for the USB 2.0 controller in embedded PPC SoCs
9 years ago
hcd-musb.c
Replace all occurances of __FUNCTION__ with __func__
9 years ago
hcd-ohci.c
ohci: set effectively usb frame rate to 1kHz
8 years ago
hcd-uhci.c
pci: Add INTERFACE_CONVENTIONAL_PCI_DEVICE to Conventional PCI devices
9 years ago
hcd-xhci-nec.c
xhci: split into multiple files
9 years ago
hcd-xhci.c
xhci: fix guest-triggerable assert
8 years ago
hcd-xhci.h
xhci: split into multiple files
9 years ago
host-libusb.c
usb-host: skip open on pending postload bh
8 years ago
host-stub.c
usb: Remove legacy -usbdevice options (host, serial, disk and net)
9 years ago
host.h
usb-host: move legacy cmd line bits
14 years ago
libhw.c
usb: Clean up includes
11 years ago
quirks-ftdi-ids.h
usbredir: Add support for buffered bulk input (v2)
14 years ago
quirks-pl2303-ids.h
usbredir: Add support for buffered bulk input (v2)
14 years ago
quirks.c
usb: Clean up includes
11 years ago
quirks.h
usbredir: Add support for buffered bulk input (v2)
14 years ago
redirect.c
hw/usb: Use the IEC binary prefix definitions
8 years ago
trace-events
trace-events: fix code style: print 0x before hex numbers
9 years ago
tusb6010.c
hw/usb/tusb6010: Convert away from old_mmio
8 years ago
xen-usb.c
xen: remove other open-coded use of libxengnttab
8 years ago
Markus Armbruster
4b5766488f