riscv/qemu: QEMU main repository: Please see https://www.qemu.org/docs/master/devel/submitting-a-patch.html for how to submit changes to QEMU. Pull Requests are ignored. Please only use release tarballs from the QEMU website. http://www.qemu.org - qemu

QEMU main repository: Please see https://www.qemu.org/docs/master/devel/submitting-a-patch.html for how to submit changes to QEMU. Pull Requests are ignored. Please only use release tarballs from the QEMU website. http://www.qemu.org

emulation kvm qemu virtualization

History

Kevin Wolf 9c707525cb nbd/server: Fix race in draining the export When draining an NBD export, nbd_drained_begin() first sets client->quiescing so that nbd_client_receive_next_request() won't start any new request coroutines. Then nbd_drained_poll() tries to makes sure that we wait for any existing request coroutines by checking that client->nb_requests has become 0. However, there is a small window between creating a new request coroutine and increasing client->nb_requests. If a coroutine is in this state, it won't be waited for and drain returns too early. In the context of switching to a different AioContext, this means that blk_aio_attached() will see client->recv_coroutine != NULL and fail its assertion. Fix this by increasing client->nb_requests immediately when starting the coroutine. Doing this after the checks if we should create a new coroutine is okay because client->lock is held. Cc: qemu-stable@nongnu.org Fixes: `fd6afc501a` ("nbd/server: Use drained block ops to quiesce the server") Signed-off-by: Kevin Wolf <kwolf@redhat.com> Message-ID: <20240314165825.40261-2-kwolf@redhat.com> Signed-off-by: Kevin Wolf <kwolf@redhat.com>		2 years ago
..
client-connection.c	nbd/client: Request extended headers during negotiation	3 years ago
client.c	nbd/client: Request extended headers during negotiation	3 years ago
common.c	nbd: Add types for extended headers	3 years ago
meson.build	nbd: move connection code from block/nbd to nbd/client-connection	5 years ago
nbd-internal.h	nbd/server: Prepare to receive extended header requests	3 years ago
server.c	nbd/server: Fix race in draining the export	2 years ago
trace-events	nbd/server: Add FLAG_PAYLOAD support to CMD_BLOCK_STATUS	3 years ago
trace.h	trace: switch position of headers to what Meson requires	6 years ago