riscv/qemu: QEMU main repository: Please see https://www.qemu.org/docs/master/devel/submitting-a-patch.html for how to submit changes to QEMU. Pull Requests are ignored. Please only use release tarballs from the QEMU website. http://www.qemu.org - qemu

QEMU main repository: Please see https://www.qemu.org/docs/master/devel/submitting-a-patch.html for how to submit changes to QEMU. Pull Requests are ignored. Please only use release tarballs from the QEMU website. http://www.qemu.org

emulation kvm qemu virtualization

History

Peter Xu 7e0c22d585 io/crypto: Move tls premature termination handling into QIO layer QCryptoTLSSession allows TLS premature termination in two cases, one of the case is when the channel shutdown() is invoked on READ side. It's possible the shutdown() happened after the read thread blocked at gnutls_record_recv(). In this case, we should allow the premature termination to happen. The problem is by the time qcrypto_tls_session_read() was invoked, tioc->shutdown may not have been set, so this may instead be treated as an error if there is concurrent shutdown() calls. To allow the flag to reflect the latest status of tioc->shutdown, move the check upper into the QIOChannel level, so as to read the flag only after QEMU gets an GNUTLS_E_PREMATURE_TERMINATION. When at it, introduce qio_channel_tls_allow_premature_termination() helper to make the condition checks easier to read. When doing so, change the qatomic_load_acquire() to qatomic_read(): here we don't need any ordering of memory accesses, but reading a flag. qatomic_read() would suffice because it guarantees fetching from memory. Nothing else we should need to order on memory access. This patch will fix a qemu qtest warning when running the preempt tls test, reporting premature termination: QTEST_QEMU_BINARY=./qemu-system-x86_64 ./tests/qtest/migration-test --full -r /x86_64/migration/postcopy/preempt/tls/psk ... qemu-kvm: Cannot read from TLS channel: The TLS connection was non-properly terminated. ... In this specific case, the error was set by postcopy_preempt_thread, which normally will be concurrently shutdown()ed by the main thread. Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> Reviewed-by: Juraj Marcin <jmarcin@redhat.com> Reviewed-by: Fabiano Rosas <farosas@suse.de> Link: https://lore.kernel.org/r/20250918203937.200833-2-peterx@redhat.com Signed-off-by: Peter Xu <peterx@redhat.com>		7 months ago
..
channel-buffer.c	qom: Have class_init() take a const data argument	12 months ago
channel-command.c	treewide: use qemu_set_blocking instead of g_unix_set_fd_nonblocking	7 months ago
channel-file.c	treewide: use qemu_set_blocking instead of g_unix_set_fd_nonblocking	7 months ago
channel-null.c	qom: Have class_init() take a const data argument	12 months ago
channel-socket.c	error: Kill @error_warn	7 months ago
channel-tls.c	io/crypto: Move tls premature termination handling into QIO layer	7 months ago
channel-util.c	io: follow coroutine AioContext in qio_channel_yield()	3 years ago
channel-watch.c	error: Kill @error_warn	7 months ago
channel-websock.c	treewide: handle result of qio_channel_set_blocking()	7 months ago
channel.c	treewide: handle result of qio_channel_set_blocking()	7 months ago
dns-resolver.c	io: Fix partial struct copy in qio_dns_resolver_lookup_sync_inet()	11 months ago
meson.build	Revert "meson: Propagate gnutls dependency"	2 years ago
net-listener.c	io: Stop appending -listen to net listeners	2 years ago
task.c	io: Fix Lesser GPL version number	6 years ago
trace-events	io: tls: Add qio_channel_tls_bye	1 year ago
trace.h	trace: switch position of headers to what Meson requires	6 years ago