riscv/qemu: QEMU main repository: Please see https://www.qemu.org/docs/master/devel/submitting-a-patch.html for how to submit changes to QEMU. Pull Requests are ignored. Please only use release tarballs from the QEMU website. http://www.qemu.org - qemu

QEMU main repository: Please see https://www.qemu.org/docs/master/devel/submitting-a-patch.html for how to submit changes to QEMU. Pull Requests are ignored. Please only use release tarballs from the QEMU website. http://www.qemu.org

emulation kvm qemu virtualization

History

Peter Maydell 7de8587b53 net: mark struct tcp_header as QEMU_PACKED The eth_header is not actually guaranteed to be aligned. We attempt to deal with this in some places such as net_checksum_calculate() by using lduw_be_p() and so on to access the fields, but this is not sufficient to be correct, because even accessing a byte member within a misaligned struct is undefined behaviour. The clang sanitizer will emit an error like this if you run the sifive_u_mmc functional test with sanitizers enabled: ../../net/checksum.c:144:24: runtime error: member access within misaligned address 0x619a74c32033 for type 'tcp_header' (aka 'struct tcp_header'), which requires 4 byte alignment 0x619a74c32033: note: pointer points here 0a 00 02 02 86 aa 00 16 52 c1 d3 70 00 00 00 00 a0 02 fa f0 00 00 00 00 02 04 05 b4 04 02 08 0a ^ #0 0x619a6ba84794 in net_checksum_calculate /home/pm215/qemu/build/clang/../../net/checksum.c:144:24 #1 0x619a6b5940da in gem_transmit /home/pm215/qemu/build/clang/../../hw/net/cadence_gem.c:1386:21 #2 0x619a6b592141 in gem_write /home/pm215/qemu/build/clang/../../hw/net/cadence_gem.c:1650:13 Fix this by marking the tcp_header struct as QEMU_PACKED. Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> Reviewed-by: Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp> Message-ID: <20260212140917.1443253-6-peter.maydell@linaro.org> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>		2 months ago
..
announce.h	net: remove AnnounceTimer from typedefs.h	2 years ago
can_emu.h	qom: remove redundant typedef when use OBJECT_DECLARE_SIMPLE_TYPE	5 months ago
can_host.h	qom: fix objects with improper parent type	6 years ago
checksum.h	net: checksum: Convert data to void *	1 year ago
eth.h	net: mark struct tcp_header as QEMU_PACKED	1 month ago
filter.h	qapi: Move @String out of common.json to discourage reuse	2 years ago
net.h	include: move hw/qdev-properties-system.h to hw/core/	3 months ago
queue.h	net: Remove deadcode	2 years ago
slirp.h	net: Remove the deprecated -tftp, -bootp, -redir and -smb options	8 years ago
tap.h	net: Add get_vhost_net callback to NetClientInfo	9 months ago
vhost-vdpa.h	net: Consolidate vhost feature bits into vhost_net structure	9 months ago
vhost_net.h	vhost-net: implement extended features support	6 months ago