riscv/qemu: QEMU main repository: Please see https://www.qemu.org/docs/master/devel/submitting-a-patch.html for how to submit changes to QEMU. Pull Requests are ignored. Please only use release tarballs from the QEMU website. http://www.qemu.org - qemu

QEMU main repository: Please see https://www.qemu.org/docs/master/devel/submitting-a-patch.html for how to submit changes to QEMU. Pull Requests are ignored. Please only use release tarballs from the QEMU website. http://www.qemu.org

emulation kvm qemu virtualization

History

Peter Maydell 0dbc2392d8 hw/dma/omap_dma: Remove omap_badwidth_* calls The omap_badwidth_read* and omap_badwidth_write* functions are used by various OMAP devices when the guest makes an access to registers with an invalid width; they do two things: - log a GUEST_ERROR for the access - call cpu_physical_memory_read() or cpu_physical_memory_write() with the offset they are passed in The first of these produces an unhelpful log message because the function name that is printed is that of the omap-badwidth_* function, not that of the read or write function of the device that called it; this means you can't tell what device is involved. The second is wrong because the offset is an offset into the device but we use it as an absolute physical address, so we will access whatever is at low memory. That happens to be the boot ROM, so we will ignore a write and return random garbage on a read. This bug has been present since 2011, when we did the conversions to the MemoryRegion APIs, which involved changing all devices from working with absolute physical addresses to working with offsets within their MemoryRegions. We must have missed updating these functions. Replace the uses of these functions in omap_dma.c with an open-coded call to qemu_log_mask() and RAZ/WI behaviour. Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>		2 months ago
..
Kconfig	hw/dma: Implement a Xilinx CSU DMA model	5 years ago
bcm2835_dma.c	include: move hw/irq.h to hw/core/	3 months ago
i8257.c	include: reorganize memory API headers	3 months ago
i82374.c	include: move hw/qdev-properties.h to hw/core/	3 months ago
meson.build	hw/dma: Remove pxa2xx_dma	2 years ago
omap_dma.c	hw/dma/omap_dma: Remove omap_badwidth_* calls	2 months ago
pl080.c	include: move hw/hw.h to hw/core/, rename	3 months ago
pl330.c	include: move hw/sysbus.h to hw/core/	3 months ago
rc4030.c	include: reorganize memory API headers	3 months ago
sifive_pdma.c	include: reorganize memory API headers	3 months ago
soc_dma.c	hw/dma: avoid apparent overflow in soc_dma_set_request	2 years ago
sparc32_dma.c	hw/sparc: Mark SPARC-specific peripherals as big-endian	3 months ago
trace-events	hw/dma: Add a trace log for a description loading failure	2 years ago
trace.h	trace: switch position of headers to what Meson requires	6 years ago
xilinx_axidma.c	include: move hw/hw.h to hw/core/, rename	3 months ago
xlnx-zdma.c	include: move hw/qdev-properties.h to hw/core/	3 months ago
xlnx-zynq-devcfg.c	include: move hw/irq.h to hw/core/	3 months ago
xlnx_csu_dma.c	include: move hw/sysbus.h to hw/core/	3 months ago
xlnx_dpdma.c	include: move hw/irq.h to hw/core/	3 months ago