Browse Source

system/physmem: Remove legacy cpu_physical_memory_rw()

The legacy cpu_physical_memory_rw() method is no more used,
remove it.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20251002084203.63899-16-philmd@linaro.org>
pull/305/head
Philippe Mathieu-Daudé 6 months ago
parent
commit
e98ae807c4
  1. 4
      docs/devel/loads-stores.rst
  2. 2
      include/exec/cpu-common.h
  3. 10
      scripts/coccinelle/exec_rw_const.cocci
  4. 7
      system/physmem.c

4
docs/devel/loads-stores.rst

@ -460,10 +460,8 @@ For new code they are better avoided:
``cpu_physical_memory_write`` ``cpu_physical_memory_write``
``cpu_physical_memory_rw``
Regexes for git grep: Regexes for git grep:
- ``\<cpu_physical_memory_\(read\|write\|rw\)\>`` - ``\<cpu_physical_memory_\(read\|write\)\>``
``cpu_memory_rw_debug`` ``cpu_memory_rw_debug``
~~~~~~~~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~

2
include/exec/cpu-common.h

@ -131,8 +131,6 @@ void cpu_address_space_init(CPUState *cpu, int asidx,
*/ */
void cpu_destroy_address_spaces(CPUState *cpu); void cpu_destroy_address_spaces(CPUState *cpu);
void cpu_physical_memory_rw(hwaddr addr, void *buf,
hwaddr len, bool is_write);
void cpu_physical_memory_read(hwaddr addr, void *buf, hwaddr len); void cpu_physical_memory_read(hwaddr addr, void *buf, hwaddr len);
void cpu_physical_memory_write(hwaddr addr, const void *buf, hwaddr len); void cpu_physical_memory_write(hwaddr addr, const void *buf, hwaddr len);
void *cpu_physical_memory_map(hwaddr addr, void *cpu_physical_memory_map(hwaddr addr,

10
scripts/coccinelle/exec_rw_const.cocci

@ -21,13 +21,6 @@ expression E1, E2, E3, E4, E5;
+ address_space_rw(E1, E2, E3, E4, E5, true) + address_space_rw(E1, E2, E3, E4, E5, true)
| |
- cpu_physical_memory_rw(E1, E2, E3, 0)
+ cpu_physical_memory_rw(E1, E2, E3, false)
|
- cpu_physical_memory_rw(E1, E2, E3, 1)
+ cpu_physical_memory_rw(E1, E2, E3, true)
|
- cpu_physical_memory_map(E1, E2, 0) - cpu_physical_memory_map(E1, E2, 0)
+ cpu_physical_memory_map(E1, E2, false) + cpu_physical_memory_map(E1, E2, false)
| |
@ -81,9 +74,6 @@ type T;
+ address_space_write_rom(E1, E2, E3, E4, E5) + address_space_write_rom(E1, E2, E3, E4, E5)
| |
- cpu_physical_memory_rw(E1, (T *)(E2), E3, E4)
+ cpu_physical_memory_rw(E1, E2, E3, E4)
|
- cpu_physical_memory_read(E1, (T *)(E2), E3) - cpu_physical_memory_read(E1, (T *)(E2), E3)
+ cpu_physical_memory_read(E1, E2, E3) + cpu_physical_memory_read(E1, E2, E3)
| |

7
system/physmem.c

@ -3179,13 +3179,6 @@ MemTxResult address_space_set(AddressSpace *as, hwaddr addr,
return error; return error;
} }
void cpu_physical_memory_rw(hwaddr addr, void *buf,
hwaddr len, bool is_write)
{
address_space_rw(&address_space_memory, addr, MEMTXATTRS_UNSPECIFIED,
buf, len, is_write);
}
void cpu_physical_memory_read(hwaddr addr, void *buf, hwaddr len) void cpu_physical_memory_read(hwaddr addr, void *buf, hwaddr len)
{ {
address_space_read(&address_space_memory, addr, address_space_read(&address_space_memory, addr,

Loading…
Cancel
Save