Browse Source

tests/functional/x86_64/test_virtio_balloon: Fix cosmetic issues from pylint

Pylint complains about some style issues in this file: Unused variables
should be marked with an underscore, "when > then and when < now"
can be simplified to "now > when > then" and expectData doesn't conform
to the usual snake_case naming style.

Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>
Message-ID: <20251029075342.47335-1-thuth@redhat.com>
pull/307/head
Thomas Huth 10 months ago
parent
commit
8e833cbf11
  1. 8
      tests/functional/x86_64/test_virtio_balloon.py

8
tests/functional/x86_64/test_virtio_balloon.py

@ -66,7 +66,7 @@ class VirtioBalloonx86(QemuSystemTest):
when = ret.get('last-update')
assert when == 0
stats = ret.get('stats')
for name, val in stats.items():
for _name, val in stats.items():
assert val == UNSET_STATS_VALUE
def assert_running_stats(self, then):
@ -87,10 +87,10 @@ class VirtioBalloonx86(QemuSystemTest):
now = time.time()
assert when > then and when < now
assert now > when > then
stats = ret.get('stats')
# Stat we expect this particular Kernel to have set
expectData = [
expect_data = [
"stat-available-memory",
"stat-disk-caches",
"stat-free-memory",
@ -103,7 +103,7 @@ class VirtioBalloonx86(QemuSystemTest):
"stat-total-memory",
]
for name, val in stats.items():
if name in expectData:
if name in expect_data:
assert val != UNSET_STATS_VALUE
else:
assert val == UNSET_STATS_VALUE

Loading…
Cancel
Save