Browse Source

qapi/parser: fix comment parsing immediately following a doc block

If a comment immediately follows a doc block, the parser doesn't ignore
that token appropriately. Fix that.

e.g.

> ##
> # = Hello World!
> ##
>
> # I'm a comment!

will break the parser, because it does not properly ignore the comment
token if it immediately follows a doc block.

Fixes: 3d035cd2cc (qapi: Rewrite doc comment parser)
Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Message-ID: <20240626222128.406106-7-jsnow@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
pull/286/head
John Snow 2 years ago
committed by Markus Armbruster
parent
commit
83deda8769
  1. 2
      scripts/qapi/parser.py
  2. 2
      tests/qapi-schema/doc-good.json

2
scripts/qapi/parser.py

@ -583,7 +583,7 @@ class QAPISchemaParser:
line = self.get_doc_line()
first = False
self.accept(False)
self.accept()
doc.end()
return doc

2
tests/qapi-schema/doc-good.json

@ -55,6 +55,8 @@
# - {braces}
##
# Not a doc comment
##
# @Enum:
#

Loading…
Cancel
Save