Browse Source

mc146818rtc: rtc_set_time(): initialize tm to zeroes

set_time() function doesn't set all the fields, so it's better to
initialize tm structure. And Coverity will be happier about it.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Maksim Davydov <davydov-max@yandex-team.ru>
Message-id: 20231017125941.810461-4-vsementsov@yandex-team.ru
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
pull/257/head
Vladimir Sementsov-Ogievskiy 2 years ago
committed by Peter Maydell
parent
commit
394bca2fa4
  1. 2
      hw/rtc/mc146818rtc.c

2
hw/rtc/mc146818rtc.c

@ -599,7 +599,7 @@ static void rtc_get_time(MC146818RtcState *s, struct tm *tm)
static void rtc_set_time(MC146818RtcState *s)
{
struct tm tm;
struct tm tm = {};
g_autofree const char *qom_path = object_get_canonical_path(OBJECT(s));
rtc_get_time(s, &tm);

Loading…
Cancel
Save