diff --git a/hw/hppa/machine.c b/hw/hppa/machine.c index 5d0d4de09e..6b69a304c2 100644 --- a/hw/hppa/machine.c +++ b/hw/hppa/machine.c @@ -179,19 +179,21 @@ static uint64_t linux_kernel_virt_to_phys(void *opaque, uint64_t addr) return addr; } +static HPPACPU *cpu[HPPA_MAX_CPUS]; +static uint64_t firmware_entry; + static uint64_t translate_pa10(void *dummy, uint64_t addr) { - return hppa_abs_to_phys_pa1x(addr); + const uint8_t pa_bits = hppa_phys_addr_bits(&cpu[0]->env); + return hppa_abs_to_phys_pa1x(pa_bits, addr); } static uint64_t translate_pa20(void *dummy, uint64_t addr) { - return hppa_abs_to_phys_pa2_w0(addr); + const uint8_t pa_bits = hppa_phys_addr_bits(&cpu[0]->env); + return hppa_abs_to_phys_pa2_w0(pa_bits, addr); } -static HPPACPU *cpu[HPPA_MAX_CPUS]; -static uint64_t firmware_entry; - static void fw_cfg_boot_set(void *opaque, const char *boot_device, Error **errp) { @@ -685,6 +687,9 @@ static AstroState *astro_init(void) DeviceState *dev; dev = qdev_new(TYPE_ASTRO_CHIP); + object_property_set_int(OBJECT(dev), "phys-addr-bits", + hppa_phys_addr_bits(&cpu[0]->env), + &error_abort); sysbus_realize_and_unref(SYS_BUS_DEVICE(dev), &error_fatal); return ASTRO_CHIP(dev); diff --git a/hw/pci-host/astro.c b/hw/pci-host/astro.c index 00a904277c..626aa9ce22 100644 --- a/hw/pci-host/astro.c +++ b/hw/pci-host/astro.c @@ -303,7 +303,7 @@ static IOMMUTLBEntry astro_translate_iommu(IOMMUMemoryRegion *iommu, * language which not-coincidentally matches the PSW.W=0 mapping. */ if (addr <= UINT32_MAX) { - entry = hppa_abs_to_phys_pa2_w0(addr); + entry = hppa_abs_to_phys_pa2_w0(s->phys_addr_bits, addr); } else { entry = addr; } @@ -910,6 +910,10 @@ static void astro_realize(DeviceState *obj, Error **errp) } } +static const Property astro_props[] = { + DEFINE_PROP_UINT8("phys-addr-bits", AstroState, phys_addr_bits, 32), +}; + static void astro_class_init(ObjectClass *klass, const void *data) { DeviceClass *dc = DEVICE_CLASS(klass); @@ -922,6 +926,8 @@ static void astro_class_init(ObjectClass *klass, const void *data) * be created without that hardware */ dc->user_creatable = false; + + device_class_set_props(dc, astro_props); } static const TypeInfo astro_chip_info = { diff --git a/include/hw/pci-host/astro.h b/include/hw/pci-host/astro.h index 832125a05a..fce052c9f8 100644 --- a/include/hw/pci-host/astro.h +++ b/include/hw/pci-host/astro.h @@ -82,6 +82,8 @@ struct AstroState { uint64_t tlb_tcnfg; uint64_t tlb_pdir_base; + uint8_t phys_addr_bits; + struct ElroyState *elroy[ELROY_NUM]; MemoryRegion this_mem; diff --git a/target/hppa/cpu.c b/target/hppa/cpu.c index cc755da8be..5895b9d7c0 100644 --- a/target/hppa/cpu.c +++ b/target/hppa/cpu.c @@ -283,6 +283,11 @@ static void hppa_cpu_class_base_init(ObjectClass *oc, const void *data) /* Make sure all CPU models define a HPPACPUDef */ g_assert(!object_class_is_abstract(oc) && data != NULL); acc->def = data; + /* + * Verify assumptions made in hppa_abs_to_phys_pa2_w1() on the size + * of the physical address space. + */ + g_assert(acc->def->phys_addr_bits <= 54); } static void hppa_cpu_class_init(ObjectClass *oc, const void *data) diff --git a/target/hppa/cpu.h b/target/hppa/cpu.h index 43b4882fb4..7d47afe8ef 100644 --- a/target/hppa/cpu.h +++ b/target/hppa/cpu.h @@ -320,6 +320,11 @@ static inline const HPPACPUDef *hppa_def(CPUHPPAState *env) return HPPA_CPU_GET_CLASS(env_cpu(env))->def; } +static inline uint8_t hppa_phys_addr_bits(CPUHPPAState *env) +{ + return hppa_def(env)->phys_addr_bits; +} + static inline bool hppa_is_pa20(CPUHPPAState *env) { return hppa_def(env)->is_pa20; @@ -352,9 +357,9 @@ static inline vaddr hppa_form_gva(CPUHPPAState *env, uint64_t spc, return hppa_form_gva_mask(env->gva_offset_mask, spc, off); } -hwaddr hppa_abs_to_phys_pa1x(vaddr addr); -hwaddr hppa_abs_to_phys_pa2_w0(vaddr addr); -hwaddr hppa_abs_to_phys_pa2_w1(vaddr addr); +hwaddr hppa_abs_to_phys_pa1x(uint8_t phys_addr_bits, vaddr addr); +hwaddr hppa_abs_to_phys_pa2_w0(uint8_t phys_addr_bits, vaddr addr); +hwaddr hppa_abs_to_phys_pa2_w1(uint8_t phys_addr_bits, vaddr addr); /* * Since PSW_{I,CB} will never need to be in tb->flags, reuse them. diff --git a/target/hppa/mem_helper.c b/target/hppa/mem_helper.c index 9199d1e06a..a4b382069d 100644 --- a/target/hppa/mem_helper.c +++ b/target/hppa/mem_helper.c @@ -29,29 +29,12 @@ #include "hw/core/cpu.h" #include "trace.h" -/* - * 64-bit (PA-RISC 2.0) machines are assumed to run PA-8700, and 32-bit - * machines 7300LC. This should give 44 and 32 bits of physical address - * space respectively. - * - * CPU model Physical address space bits - * PA-7000--7300LC 32 - * PA-8000--8600 40 - * PA-8700--8900 44 - * - * FIXME: However, the SeaBIOS firmware that is that tested against - * uses 40-bit physical addresses, despite supposedly running a C3700 - * with a PA-8700 cpu, so use 40-bits for 64-bit. - */ -#define HPPA_PHYS_ADDR_SPACE_BITS_PA20 40 -#define HPPA_PHYS_ADDR_SPACE_BITS_PA1X 32 - -hwaddr hppa_abs_to_phys_pa1x(vaddr addr) +hwaddr hppa_abs_to_phys_pa1x(uint8_t phys_addr_bits, vaddr addr) { - return extract64(addr, 0, HPPA_PHYS_ADDR_SPACE_BITS_PA1X); + return extract64(addr, 0, phys_addr_bits); } -hwaddr hppa_abs_to_phys_pa2_w1(vaddr addr) +hwaddr hppa_abs_to_phys_pa2_w1(uint8_t phys_addr_bits, vaddr addr) { /* * Figure H-8 "62-bit Absolute Accesses when PSW W-bit is 1" describes @@ -64,11 +47,10 @@ hwaddr hppa_abs_to_phys_pa2_w1(vaddr addr) * Since the supported physical address space is below 54 bits, the * H-8 algorithm is moot and all that is left is to truncate. */ - QEMU_BUILD_BUG_ON(HPPA_PHYS_ADDR_SPACE_BITS_PA20 > 54); - return sextract64(addr, 0, HPPA_PHYS_ADDR_SPACE_BITS_PA20); + return sextract64(addr, 0, phys_addr_bits); } -hwaddr hppa_abs_to_phys_pa2_w0(vaddr addr) +hwaddr hppa_abs_to_phys_pa2_w0(uint8_t phys_addr_bits, vaddr addr) { /* * See Figure H-10, "Absolute Accesses when PSW W-bit is 0", @@ -89,7 +71,7 @@ hwaddr hppa_abs_to_phys_pa2_w0(vaddr addr) * is what can be seen on physical machines too. */ addr = (uint32_t)addr; - addr |= -1ull << (HPPA_PHYS_ADDR_SPACE_BITS_PA20 - 4); + addr |= -1ull << (phys_addr_bits - 4); } return addr; } @@ -231,15 +213,16 @@ int hppa_get_physical_address(CPUHPPAState *env, vaddr addr, int mmu_idx, /* Virtual translation disabled. Map absolute to physical. */ if (MMU_IDX_MMU_DISABLED(mmu_idx)) { + const uint8_t phys_addr_bits = hppa_phys_addr_bits(env); switch (mmu_idx) { case MMU_ABS_W_IDX: - phys = hppa_abs_to_phys_pa2_w1(addr); + phys = hppa_abs_to_phys_pa2_w1(phys_addr_bits, addr); break; case MMU_ABS_IDX: if (hppa_is_pa20(env)) { - phys = hppa_abs_to_phys_pa2_w0(addr); + phys = hppa_abs_to_phys_pa2_w0(phys_addr_bits, addr); } else { - phys = hppa_abs_to_phys_pa1x(addr); + phys = hppa_abs_to_phys_pa1x(phys_addr_bits, addr); } break; default: @@ -580,7 +563,7 @@ static void itlbt_pa20(CPUHPPAState *env, target_ulong r1, /* Align per the page size. */ ent->pa &= TARGET_PAGE_MASK << mask_shift; /* Ignore the bits beyond physical address space. */ - ent->pa = sextract64(ent->pa, 0, HPPA_PHYS_ADDR_SPACE_BITS_PA20); + ent->pa = sextract64(ent->pa, 0, hppa_phys_addr_bits(env)); ent->t = extract64(r2, 61, 1); ent->d = extract64(r2, 60, 1);