Browse Source

tests/functional: Enforce sha256 as hashsum algorithm for all tests

The functional testing framework currently supports both, sha256
and sha512 as hashsums for the assets. However, all but one test
currently only use sha256, which should also be sufficient according
to the current security standards. Having two algorithms around already
caused some confusion (e.g. the clean_functional_cache.py script only
supports sha256 right now), so standardize now on enforcing sha256
before more tests use a mix of the two algorithms.

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Aditya Gupta <adityag@linux.ibm.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
Message-ID: <20260121101957.82477-1-thuth@redhat.com>
pull/319/head
Thomas Huth 2 months ago
parent
commit
161ea5a634
  1. 4
      tests/functional/ppc64/test_fadump.py
  2. 4
      tests/functional/qemu_test/asset.py

4
tests/functional/ppc64/test_fadump.py

@ -32,9 +32,7 @@ class QEMUFadump(LinuxKernelTest):
ASSET_VMLINUZ_KERNEL = Asset(
('https://archives.fedoraproject.org/pub/archive/fedora-secondary/'
'releases/39/Everything/ppc64le/os/ppc/ppc64/vmlinuz'),
('81e5541d243b50c8f9568906c6918dda22239744d637bb9a7b22d23c3d661226'
'8d5302beb2ca5c06f93bdbc9736c414ef5120756c8bf496ff488ad07d116d67f')
)
'6d77658130a7de1dd014ae14d7983c27f8ba1a61fa02e8d9064afdb8519e7e96')
ASSET_FEDORA_INITRD = Asset(
('https://archives.fedoraproject.org/pub/archive/fedora-secondary/'

4
tests/functional/qemu_test/asset.py

@ -57,10 +57,8 @@ class Asset:
return True
if len(self.hash) == 64:
hl = hashlib.sha256()
elif len(self.hash) == 128:
hl = hashlib.sha512()
else:
raise AssetError(self, "unknown hash type")
raise AssetError(self, "unsupported hash type")
# Calculate the hash of the file:
with open(cache_file, 'rb') as file:

Loading…
Cancel
Save