Browse Source

tests/qtest/migration: Initialize buffer in probe_o_direct_support

Valgrind complains about the probe_o_direct_support() function reading
from an uninitialized buffer. For probing O_DIRECT support we don't
actually need to write to the file, just make sure the pwrite call
doesn't reject the write. Still, write zeroes to the buffer to
suppress the warning.

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Peter Xu <peterx@redhat.com>
Message-Id: <20241209204427.17763-3-farosas@suse.de>
Signed-off-by: Fabiano Rosas <farosas@suse.de>
pull/278/head
Fabiano Rosas 1 year ago
parent
commit
117221ad99
  1. 1
      tests/qtest/migration/migration-util.c

1
tests/qtest/migration/migration-util.c

@ -284,6 +284,7 @@ bool probe_o_direct_support(const char *tmpfs)
buf = qemu_try_memalign(len, len);
g_assert(buf);
memset(buf, 0, len);
ret = pwrite(fd, buf, len, offset);
unlink(filename);

Loading…
Cancel
Save