Browse Source

restore _Noreturn to __assert_fail

this reverts commit 2c1f8fd5da. without
the _Noreturn attribute, the compiler cannot use asserts to perform
reachability/range analysis. this leads to missed optimizations and
spurious warnings.

the original backtrace problem that prompted the removal of _Noreturn
was not clearly documented at the time, but it seems to happen only
when libc was built without -g, which also breaks many other
backtracing cases.
master
Rich Felker 10 years ago
parent
commit
e738b8cbe6
  1. 2
      include/assert.h
  2. 2
      src/exit/assert.c

2
include/assert.h

@ -16,7 +16,7 @@
extern "C" {
#endif
void __assert_fail (const char *, const char *, int, const char *);
_Noreturn void __assert_fail (const char *, const char *, int, const char *);
#ifdef __cplusplus
}

2
src/exit/assert.c

@ -1,7 +1,7 @@
#include <stdio.h>
#include <stdlib.h>
void __assert_fail(const char *expr, const char *file, int line, const char *func)
_Noreturn void __assert_fail(const char *expr, const char *file, int line, const char *func)
{
fprintf(stderr, "Assertion failed: %s (%s: %s: %d)\n", expr, file, func, line);
fflush(NULL);

Loading…
Cancel
Save