Browse Source

getopt: fix null pointer arithmetic ub

When an option that requires an argument is the last character of
argv[argc-1], getopt computes argv[argc] + optpos. While optpos
is always zero in this case, adding it to null pointer is still
undefined.
master
Alexey Izbyshev 3 years ago
committed by Rich Felker
parent
commit
6d322159c6
  1. 3
      src/misc/getopt.c

3
src/misc/getopt.c

@ -87,7 +87,8 @@ int getopt(int argc, char * const argv[], const char *optstring)
if (optstring[i] == ':') {
optarg = 0;
if (optstring[i+1] != ':' || optpos) {
optarg = argv[optind++] + optpos;
optarg = argv[optind++];
if (optpos) optarg += optpos;
optpos = 0;
}
if (optind > argc) {

Loading…
Cancel
Save