mirror of https://git.musl-libc.org/git/musl
Browse Source
the Linux SYS_nice syscall is unusable because it does not return the newly set priority. always use SYS_setpriority. also avoid overflows in addition of inc by handling large inc values directly without examining the old nice value.master
1 changed files with 9 additions and 5 deletions
@ -1,12 +1,16 @@ |
|||||
#include <unistd.h> |
#include <unistd.h> |
||||
#include <sys/resource.h> |
#include <sys/resource.h> |
||||
|
#include <limits.h> |
||||
#include "syscall.h" |
#include "syscall.h" |
||||
|
|
||||
int nice(int inc) |
int nice(int inc) |
||||
{ |
{ |
||||
#ifdef SYS_nice |
int prio = inc; |
||||
return syscall(SYS_nice, inc); |
// Only query old priority if it can affect the result.
|
||||
#else |
// This also avoids issues with integer overflow.
|
||||
return setpriority(PRIO_PROCESS, 0, getpriority(PRIO_PROCESS, 0)+inc); |
if (inc > -2*NZERO && inc < 2*NZERO) |
||||
#endif |
prio += getpriority(PRIO_PROCESS, 0); |
||||
|
if (prio > NZERO-1) prio = NZERO-1; |
||||
|
if (prio < -NZERO) prio = -NZERO; |
||||
|
return setpriority(PRIO_PROCESS, 0, prio) ? -1 : prio; |
||||
} |
} |
||||
|
|||||
Loading…
Reference in new issue