mirror of https://git.musl-libc.org/git/musl
Browse Source
this fixes a major gap in the intended functionality of pthread_setattr_default_np. if application/library code creating a thread does not pass a null attribute pointer to pthread_create, but sets up an attribute object to change other properties while leaving the stack alone, the created thread will get a stack with size DEFAULT_STACK_SIZE. this makes pthread_setattr_default_np useless for working around stack overflow issues in such applications, and leaves a major risk of regression if previously-working code switches from using a null attribute pointer to an attribute object. this change aligns the behavior more closely with the glibc pthread_setattr_default_np functionality too, albeit via a different mechanism. glibc encodes "default" specially in the attribute object and reads the actual default at thread creation time. with this commit, we now copy the current default into the attribute object at pthread_attr_init time, so that applications that query the properties of the attribute object will see the right values.master
3 changed files with 11 additions and 4 deletions
@ -0,0 +1,4 @@ |
|||
#include "pthread_impl.h" |
|||
|
|||
size_t __default_stacksize = DEFAULT_STACK_SIZE; |
|||
size_t __default_guardsize = DEFAULT_GUARD_SIZE; |
|||
@ -1,9 +1,12 @@ |
|||
#include "pthread_impl.h" |
|||
|
|||
extern size_t __default_stacksize; |
|||
extern size_t __default_guardsize; |
|||
|
|||
int pthread_attr_init(pthread_attr_t *a) |
|||
{ |
|||
*a = (pthread_attr_t){0}; |
|||
a->_a_stacksize = DEFAULT_STACK_SIZE; |
|||
a->_a_guardsize = DEFAULT_GUARD_SIZE; |
|||
a->_a_stacksize = __default_stacksize; |
|||
a->_a_guardsize = __default_guardsize; |
|||
return 0; |
|||
} |
|||
|
|||
Loading…
Reference in new issue